feat: push tests down - test more at go level - #569
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces several Earthfile test fixtures to validate various valid and invalid VERSION formats, along with corresponding unit tests in ast/version_test.go. The review feedback recommends capturing the loop variables locally within the test loops before invoking parallel subtests to ensure compatibility with older Go versions and satisfy linters.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🎉 Are we earthbuild yet?Great progress! You've reduced "earthly" occurrences by 3 (0.06%) 📈 Overall Progress
📁 Changes by file type:
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
|
Had to rework it following the parsing changes. |
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
These tests are currently earthbuild integration tests, this pushes them down to be go tests. Faster tests, less to go wrong.