Skip to content

feat: push tests down - test more at go level - #569

Merged
gilescope merged 9 commits into
mainfrom
giles-ast-version-tests
Jul 28, 2026
Merged

feat: push tests down - test more at go level#569
gilescope merged 9 commits into
mainfrom
giles-ast-version-tests

Conversation

@gilescope

@gilescope gilescope commented Jun 14, 2026

Copy link
Copy Markdown

These tests are currently earthbuild integration tests, this pushes them down to be go tests. Faster tests, less to go wrong.

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
gilescope requested a review from a team as a code owner June 14, 2026 12:09
@gilescope
gilescope requested review from kmannislands and removed request for a team June 14, 2026 12:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several Earthfile test fixtures to validate various valid and invalid VERSION formats, along with corresponding unit tests in ast/version_test.go. The review feedback recommends capturing the loop variables locally within the test loops before invoking parallel subtests to ensure compatibility with older Go versions and satisfy linters.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ast/version_test.go Outdated
Comment thread ast/version_test.go Outdated
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

🎉 Are we earthbuild yet?

Great progress! You've reduced "earthly" occurrences by 3 (0.06%)

📈 Overall Progress

Branch Total Count
main 4751
This PR 4748
Difference -3 (0.06%)

📁 Changes by file type:

File Type Change
Go files (.go) ➖ No change
Documentation (.md) ➖ No change
Earthfiles ✅ -3

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope mentioned this pull request Jun 14, 2026
12 tasks
Comment thread ast/testdata/version/comment-and-whitespace-before-version.earth Outdated
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
gilescope requested a review from janishorsts July 1, 2026 07:34
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope

Copy link
Copy Markdown
Author

Had to rework it following the parsing changes.

Comment thread internal/earthfile/version_test.go Outdated
@gilescope
gilescope enabled auto-merge (squash) July 4, 2026 08:55
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>

@janishorsts janishorsts left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilescope
gilescope merged commit b8c48e6 into main Jul 28, 2026
89 checks passed
@gilescope
gilescope deleted the giles-ast-version-tests branch July 28, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants