fix(desktop): keep installed skilllite when prebuild has no engine - #174
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Standalone prebuild deleted ~/.skilllite/bin/skilllite before falling back to that same file, so a desktop build with no engine checkout removed the user's CLI and then failed. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.skilllite/bin/skilllitebefore using that same file as the fallback binary. Atauri build/npm run prebuild:tauriwith no engine checkout removed the user's CLI and then failed.~/.skilllite/bin/skilllite, it is left in place. A failed copy does not remove the previous destination.Task Linkage
N/Atasks/TASK-.../folderInjected Specs
spec/verification-integrity.mdspec/testing-policy.mdspec/docs-sync.md(reviewed; no doc change)spec/architecture-boundaries.md(not applicable)spec/security-nonnegotiables.md(not applicable)Validation Evidence
bash skilllite-assistant/scripts/test-engine-root.shHEAD:skilllite-assistant/scripts/prebuild-skilllite.shand a throwawayHOMEengine-root.sh checks passed(exit 0). The missing-source case printscp: cannot stat ... does-not-existand still leaves the destination intact.lookup_line=15,rm_line=13, order assertion FAIL.rm -f ~/.skilllite/bin/skilllite,skilllite_find_installed_binreportsLOOKUP_AFTER_DELETE: not found.cargo fmt --check,cargo clippy,cargo test. This change is shell-only underskilllite-assistant/scripts/.Regression Scope
skilllite-assistant/scripts/prebuild-skilllite.sh(beforeBuildCommand)skilllite-assistant/scripts/prebuild-skilllite-dev.sh(forced dev refresh with no engine checkout)cargo installpath (that path still replaces~/.skilllite/binafter an engine root is found)Docs Sync (EN/ZH)
Review Checklist
Task ID: N/A); no task-folder acceptance filetasks/.../STATUS.mdnot usedtasks/.../REVIEW.mdnot usedtasks/board.mdnot updated (no task folder)