fix(agent): restrict memory flush to memory tools only - #139
Draft
cursor[bot] wants to merge 2 commits into
Draft
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Silent pre-compaction flush previously ran a full agent loop under SilentEventSink, so unconfirmed mutators like write_file could rewrite the workspace. Flush turns now register memory tools only. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Record validation results, review readiness, and board status for TASK-2026-071 after agent crate tests and clippy passed. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SilentEventSinkwith builtins/skills/MCP available. Non-key-pathwrite_fileneeds no confirmation, so a silent flush could overwrite workspace files; Low-tierrun_commandcould also auto-approve after PR fix(agent): deny ConfirmRequired in SilentEventSink #138.memory_tools_onlyand build a registry that registers onlymemory_search/memory_write/memory_list(no builtins, skills, or MCP).Task Linkage
TASK-2026-071tasks/TASK-2026-071-memory-flush-tool-allowlist/Injected Specs
spec/architecture-boundaries.md(agent loop / extension registry only; no crate boundary changes)spec/security-nonnegotiables.md(silent background turn must not mutate workspace)spec/testing-policy.md(Rust code change + regression tests)spec/docs-sync.md(reviewed; not needed — no user-facing command/env/docs change)spec/verification-integrity.md,spec/task-artifact-language.md,spec/rust-conventions.mdValidation Evidence
cargo fmt --checkcargo clippy -p skilllite-agent --all-targets -- -D warningscargo test -p skilllite-agent memory_flushcargo test -p skilllite-agentpython3 scripts/validate_tasks.py2 passed(memory_flush_registry_*)249 passed; 0 failedTask validation passed (71 task folders checked)Regression Scope
run_single_taskfull tool surfaceDocs Sync (EN/ZH)
Review Checklist
tasks/TASK-2026-071-memory-flush-tool-allowlist/TASK.mdsatisfiedtasks/TASK-2026-071-memory-flush-tool-allowlist/STATUS.mdupdated with latest progresstasks/TASK-2026-071-memory-flush-tool-allowlist/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date