fix(sandbox): reject bash background and redirect injection - #137
Draft
cursor[bot] wants to merge 3 commits into
Draft
cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Bare `&`, `>`, and `<` bypassed CHAIN_OPERATORS while bash-tool skills still execute via unsandboxed sh -c, allowing host command chaining and arbitrary file writes. Harden the deny list and add regression tests. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Record validation results and mark TASK-2026-085 done on the board. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;/&&/||/|but accepted bare&,>, and<.sh -c, so an LLM/skill arg can background a second host command or redirect I/O to arbitrary paths.CHAIN_OPERATORS, add regression tests, and sync EN/ZH architecture notes.Task Linkage
TASK-2026-085-bash-validator-background-redirecttasks/TASK-2026-085-bash-validator-background-redirect/Injected Specs
spec/verification-integrity.mdspec/task-artifact-language.mdspec/security-nonnegotiables.mdspec/testing-policy.mdspec/docs-sync.mdspec/rust-conventions.mdValidation Evidence
sh -c 'agent-browser ... & touch /tmp/pwned_*'created host files even whenagent-browserwas missingcargo test -p skilllite-sandbox bash_validator→ 25 passedcargo clippy -p skilllite-sandbox --all-targets -- -D warnings→ cleancargo fmt --check→ cleanpython3 scripts/validate_tasks.py→ 71 task folders passed&, tight&,>,<, and>>agent-browser open https://example.comstill ACCEPTsRegression Scope
skilllite-agent/skilllite-commandsDocs Sync (EN/ZH)
docs/en/ARCHITECTURE.mddocs/zh/ARCHITECTURE.mdReview Checklist
tasks/TASK-2026-085-bash-validator-background-redirect/TASK.mdsatisfiedSTATUS.mdupdated with latest progressREVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to dateSecurity review notes
&,>,<)SKILLLITE_*config semantic change