Repository navigation
Windows base (2/2): windows-latest compile and tests job (stacked on #75) - #76
Merged
Merged
Conversation
New workflow windows.yml: cargo check --locked --all-targets of the Tauri wrapper for Windows plus url-policy tests, and the pytest suite on Windows minus the files in tests/windows_skips.py (each with a reason, applied on win32 only). No signing, release, artifact or secret; SHA-pinned actions; stacked on PR 8.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70132921dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ests with reasons First windows-python run: 1676 passed, 108 failed. 40 were the evals harness failing to delete a temp dir holding an open sqlite file (ignore_cleanup_errors). One test helper compared a backslash path. The rest (code sessions, macOS keychain backend, POSIX permission bits, POSIX paths, vault/skills tools not yet investigated) are skipped on win32 only, each with a reason.
…dexes backslashes) Last failure of the first Windows run: the RAG eval cases check a posix path suffix against citations whose path has backslashes on Windows. Linux/macOS unchanged.
…gainst new ones - posix_perms marker (skipped on win32 by conftest, with the reason) for tests that are about permission bits; tests/posix_perms.py helpers (no-ops on Windows) for tests where the bits are one assertion among others, so the rest still runs on Windows. - tests/test_posix_perms_guard.py fails if a test reads st_mode/S_IMODE/S_I*/ os.access(R/W/X_OK) without the marker or a helper. - Per-test entries for permission tests removed from windows_skips.py. macOS/Linux assert exactly what they did.
…patched sys.platform windows-latest run 40926549010 (windows-python, job 123633486845): 1 failed, 1707 passed. test_secrets_store_secret_service patches sys.platform to 'linux' to exercise the Linux code path, so the helper no longer saw Windows and asserted 0o600 on a real Windows file (mode 0o666). The helpers now follow the real OS; a test pins that.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows base, PR 9 of docs/PORTABILITY.md: a
windows-latestcompile-and-test jobWindows is still not supported. This only makes a Windows regression visible.
What it adds
.github/workflows/windows.yml, two jobs, bothwindows-latest(GitHub-hosted, literal label,timeout-minutes, SHA-pinned actions with version comments,permissions: contents: read):cargo check --locked --all-targetsofdesktop/src-taurifor the Windows target (with a placeholder sidecarconductloop-server-<triple>.exe, same trick as the Linux/macOS jobs) andcargo testofdesktop/url-policy. The wrapper's own tests are not run (they would link the WebView2 loader, and nothing launches the app).pip install -r requirements-dev.txt, thenpytest -m "not live"minus the live license worker, the two headless-Chrome JS tests and the*_ui_browsertests (those run inci.yml).PYTHONUTF8=1(the plan's item 8 starts the sidecar with it);core.autocrlf false.tests/windows_skips.py(bubblewrap/seatbelt sandbox, bash scripts, AF_UNIX agent bridge), applied bytests/conftest.pyonwin32only: macOS/Linux collection is unchanged.gitleaksandtest); path-filtered toops_dashboard/,tests/,desktop/, requirements,pyproject.tomland itself.Tests
tests/test_windows_workflow.py: both jobs onwindows-latestwith a timeout; nosecrets./artifact/release/sign/tauri-build words in the workflow; read-only permissions; job names do not collide with the required checks; every entry of the skip list exists and has a reason; the conftest hook skips only onwin32.tests/test_workflows_guard.pypasses unchanged (windows-latest is already allowed, ubuntu-22.04 stays only in linux-bundles).Untested
Whether the Windows Python suite passes as-is: it was never run on Windows. The skip list only contains files that obviously need Unix. If the first run shows more real Windows failures they will be fixed if small, or added to the skip list with a reason, in a follow-up commit.
Local:
scripts/verify.sh --offlinepasses ruff, mypy ratchet, evals and pytest; the Secret-scan step fails only locally because of a stale local ref (gitleaks onHEADis clean).