-
Notifications
You must be signed in to change notification settings - Fork 21
MOM_interface changes for regional setups #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manishvenu
wants to merge
25
commits into
ESCOMP:main
Choose a base branch
from
CROCODILE-CESM:regional_changes_for_croc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
001e6a1
New tests
manishvenu 4ec21f8
MOM_interface changes for regional, only todo is the mom6_domian tupe…
manishvenu e7d3055
MOM_input changes
manishvenu bd7a2b1
Fix formatting
manishvenu 3a86a50
Update MOm6 commit & add the input_nl change back
manishvenu e0f871f
Review COmments + Update MOM6 Commit
manishvenu c78ed29
Merge remote-tracking branch 'upstream/main' into regional_changes_fo…
manishvenu 458432b
Duplicate Param
manishvenu 7a5c1a8
PE Layouts
manishvenu 28deca3
Update
manishvenu 2373b84
Line Add
manishvenu 38b9aff
Reformatted BGC
manishvenu 947569c
in terms of din loc root
manishvenu a34efb3
Try Adding DIN_LOC_ROOT
manishvenu 1a29180
Changes
manishvenu 49462f7
Reduced FIle
manishvenu f74950f
Back:
manishvenu 57d19bd
Relative Path
manishvenu 5d51097
Fix Riv nutri Path
manishvenu 5423719
Change the max files/fields
manishvenu 53ca846
INPUTDIR Changes
manishvenu e27a674
Bracket
manishvenu ebc2315
Try This
manishvenu 795f8b5
Revert "Try This"
manishvenu d9e6b95
Merge branch 'ct_from_main' into regional_changes_for_croc
manishvenu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule MOM6
updated
3 files
| +6 −7 | config_src/drivers/nuopc_cap/mom_cap.F90 | |
| +104 −6 | src/tracer/MARBL_tracers.F90 | |
| +3 −1 | src/tracer/MOM_tracer_flow_control.F90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
cime_config/testdefs/testmods_dirs/mom/regional/base/shell_commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| ./xmlchange OCN_NX=60 | ||
| ./xmlchange OCN_NY=60 | ||
| ./xmlchange OCN_DOMAIN_MESH='${DIN_LOC_ROOT}/ocn/mom/croc/testing_data/panama/ESMF_mesh_panama1_352fd1.nc' | ||
| ./xmlchange ICE_DOMAIN_MESH='${DIN_LOC_ROOT}/ocn/mom/croc/testing_data/panama/ESMF_mesh_panama1_352fd1.nc' | ||
| ./xmlchange MASK_MESH='${DIN_LOC_ROOT}/ocn/mom/croc/testing_data/panama/ESMF_mesh_panama1_352fd1.nc' | ||
| ./xmlchange ATM_GRID=TL319 | ||
| ./xmlchange LND_GRID=TL319 | ||
| ./xmlchange ATM_DOMAIN_MESH='${DIN_LOC_ROOT}/share/meshes/TL319_151007_ESMFmesh.nc' | ||
| ./xmlchange LND_DOMAIN_MESH='${DIN_LOC_ROOT}/share/meshes/TL319_151007_ESMFmesh.nc' | ||
| ./xmlchange MOM6_MEMORY_MODE=dynamic_symmetric | ||
| ./xmlchange RUN_STARTDATE=2000-01-01 | ||
| ./xmlchange ROF2OCN_LIQ_RMAPNAME='${DIN_LOC_ROOT}/ocn/mom/croc/testing_data/panama/GLOFAS_to_panama1_map_r20_f40_nnsm.nc' | ||
| ./xmlchange ROF2OCN_ICE_RMAPNAME='${DIN_LOC_ROOT}/ocn/mom/croc/testing_data/panama/GLOFAS_to_panama1_map_r20_f40_nnsm.nc' | ||
|
|
||
| # Set PE Layout | ||
| ./xmlchange NTASKS_OCN=20 |
98 changes: 98 additions & 0 deletions
98
cime_config/testdefs/testmods_dirs/mom/regional/base/user_nl_mom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| !INPUTDIR is set by the MOM_input.yaml because it requires a hard-coded path | ||
| TRIPOLAR_N = False | ||
| REENTRANT_X = False | ||
| REENTRANT_Y = False | ||
| NIGLOBAL = 60 | ||
| NJGLOBAL = 60 | ||
| GRID_CONFIG = mosaic | ||
| GRID_FILE = ocean_hgrid_panama1_352fd1.nc | ||
| TOPO_CONFIG = file | ||
| TOPO_FILE = ocean_topog_panama1_352fd1.nc | ||
| MAXIMUM_DEPTH = 3431.7499950346473 | ||
| MINIMUM_DEPTH = 9.5 | ||
| NK = 75 | ||
| COORD_CONFIG = none | ||
| ALE_COORDINATE_CONFIG = FILE:ocean_vgrid_panama1_352fd1.nc | ||
| REGRIDDING_COORDINATE_MODE = Z* | ||
|
|
||
| ! Timesteps (based on grid resolution) | ||
| DT = 300.0 | ||
| DT_THERM = 900.0 | ||
|
|
||
| ! Enable tidal forcing in MOM6 | ||
| TIDES = True | ||
|
|
||
| ! Enable M2 tidal constituent | ||
| TIDE_M2 = True | ||
|
|
||
| ! Drag coefficient for tidal forcing | ||
| CD_TIDES = 0.0018 | ||
|
|
||
| ! Use equilibrium phase for tides | ||
| TIDE_USE_EQ_PHASE = True | ||
|
|
||
| ! Reference date for tidal forcing | ||
| TIDE_REF_DATE = 2000, 01, 01 | ||
|
|
||
| ! Add equilibrium phase to OBC tides | ||
| OBC_TIDE_ADD_EQ_PHASE = True | ||
|
|
||
| ! Number of tidal constituents | ||
| OBC_TIDE_N_CONSTITUENTS = 1 | ||
|
|
||
| ! List of tidal constituents | ||
| OBC_TIDE_CONSTITUENTS = "M2" | ||
|
|
||
| ! Reference date for OBC tidal forcing | ||
| OBC_TIDE_REF_DATE = 2000, 01, 01 | ||
|
|
||
| ! Chlorophyll data file | ||
| CHL_FILE = seawifs-clim-1997-2010-panama1.nc | ||
|
|
||
| ! Enable chlorophyll from file | ||
| CHL_FROM_FILE = TRUE | ||
|
|
||
| ! Enable variable penetration for shortwave | ||
| VAR_PEN_SW = TRUE | ||
|
|
||
| ! Number of shortwave penetration bands | ||
| PEN_SW_NBANDS = 3 | ||
|
|
||
| ! Initial conditions | ||
| INIT_LAYERS_FROM_Z_FILE = True | ||
| Z_INIT_ALE_REMAPPING = True | ||
| TEMP_SALT_INIT_VERTICAL_REMAP_ONLY = True | ||
| DEPRESS_INITIAL_SURFACE = True | ||
| VELOCITY_CONFIG = file | ||
| TEMP_SALT_Z_INIT_FILE = init_tracers.nc | ||
| SURFACE_HEIGHT_IC_FILE = init_eta.nc | ||
| VELOCITY_FILE = init_vel.nc | ||
| Z_INIT_FILE_PTEMP_VAR = temp | ||
| Z_INIT_FILE_SALT_VAR = salt | ||
| SURFACE_HEIGHT_IC_VAR = eta_t | ||
| U_IC_VAR = u | ||
| V_IC_VAR = v | ||
|
|
||
| ! Open boundary conditions | ||
| OBC_NUMBER_OF_SEGMENTS = 4 | ||
| OBC_FREESLIP_VORTICITY = False | ||
| OBC_FREESLIP_STRAIN = False | ||
| OBC_COMPUTED_VORTICITY = True | ||
| OBC_COMPUTED_STRAIN = True | ||
| OBC_ZERO_BIHARMONIC = True | ||
| OBC_TRACER_RESERVOIR_LENGTH_SCALE_OUT = 3.0E+04 | ||
| OBC_TRACER_RESERVOIR_LENGTH_SCALE_IN = 3000.0 | ||
| BRUSHCUTTER_MODE = True | ||
| OBC_SEGMENT_001 = "J=0,I=0:N,FLATHER,ORLANSKI,NUDGED,ORLANSKI_TAN,NUDGED_TAN" | ||
| OBC_SEGMENT_001_VELOCITY_NUDGING_TIMESCALES = 0.3, 360.0 | ||
| OBC_SEGMENT_001_DATA = "U=file:forcing_obc_segment_001.nc(u),V=file:forcing_obc_segment_001.nc(v),SSH=file:forcing_obc_segment_001.nc(eta),TEMP=file:forcing_obc_segment_001.nc(temp),SALT=file:forcing_obc_segment_001.nc(salt),Uamp=file:tu_segment_001.nc(uamp),Uphase=file:tu_segment_001.nc(uphase),Vamp=file:tu_segment_001.nc(vamp),Vphase=file:tu_segment_001.nc(vphase),SSHamp=file:tz_segment_001.nc(zamp),SSHphase=file:tz_segment_001.nc(zphase)" | ||
| OBC_SEGMENT_002 = "J=N,I=N:0,FLATHER,ORLANSKI,NUDGED,ORLANSKI_TAN,NUDGED_TAN" | ||
| OBC_SEGMENT_002_VELOCITY_NUDGING_TIMESCALES = 0.3, 360.0 | ||
| OBC_SEGMENT_002_DATA = "U=file:forcing_obc_segment_002.nc(u),V=file:forcing_obc_segment_002.nc(v),SSH=file:forcing_obc_segment_002.nc(eta),TEMP=file:forcing_obc_segment_002.nc(temp),SALT=file:forcing_obc_segment_002.nc(salt),Uamp=file:tu_segment_002.nc(uamp),Uphase=file:tu_segment_002.nc(uphase),Vamp=file:tu_segment_002.nc(vamp),Vphase=file:tu_segment_002.nc(vphase),SSHamp=file:tz_segment_002.nc(zamp),SSHphase=file:tz_segment_002.nc(zphase)" | ||
| OBC_SEGMENT_003 = "I=0,J=N:0,FLATHER,ORLANSKI,NUDGED,ORLANSKI_TAN,NUDGED_TAN" | ||
| OBC_SEGMENT_003_VELOCITY_NUDGING_TIMESCALES = 0.3, 360.0 | ||
| OBC_SEGMENT_003_DATA = "U=file:forcing_obc_segment_003.nc(u),V=file:forcing_obc_segment_003.nc(v),SSH=file:forcing_obc_segment_003.nc(eta),TEMP=file:forcing_obc_segment_003.nc(temp),SALT=file:forcing_obc_segment_003.nc(salt),Uamp=file:tu_segment_003.nc(uamp),Uphase=file:tu_segment_003.nc(uphase),Vamp=file:tu_segment_003.nc(vamp),Vphase=file:tu_segment_003.nc(vphase),SSHamp=file:tz_segment_003.nc(zamp),SSHphase=file:tz_segment_003.nc(zphase)" | ||
| OBC_SEGMENT_004 = "I=N,J=0:N,FLATHER,ORLANSKI,NUDGED,ORLANSKI_TAN,NUDGED_TAN" | ||
| OBC_SEGMENT_004_VELOCITY_NUDGING_TIMESCALES = 0.3, 360.0 | ||
| OBC_SEGMENT_004_DATA = "U=file:forcing_obc_segment_004.nc(u),V=file:forcing_obc_segment_004.nc(v),SSH=file:forcing_obc_segment_004.nc(eta),TEMP=file:forcing_obc_segment_004.nc(temp),SALT=file:forcing_obc_segment_004.nc(salt),Uamp=file:tu_segment_004.nc(uamp),Uphase=file:tu_segment_004.nc(uphase),Vamp=file:tu_segment_004.nc(vamp),Vphase=file:tu_segment_004.nc(vphase),SSHamp=file:tz_segment_004.nc(zamp),SSHphase=file:tz_segment_004.nc(zphase)" | ||
| ! We need to add one line at the end so we can concatenate other testing user_nl_mom files (if you don't they just get added to the last line) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dabail10 and I were talking, and we probably want a CICE modifier as well (e.g.
CICE%REGIONAL). Now that open boundary conditions are available in CICE, he's going to test that code out but eventually CICE will want to be able to configure regional domains.Two notes:
CICEtoCICE%<something_else>will not change answers if CICE'sconfig_component.xmldoesn't know what to do with the new modifier, but it's worth testing that hypothesisCICE%REGIONALis my first thought, but @dabail10 may propose a better modifierThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be another PR? Or can CICE use the MOM6 regional? Because you can't have one without the other?