Skip to content

Add a shareable generic datamode#412

Open
NickSzapiro-NOAA wants to merge 25 commits into
ESCOMP:mainfrom
NickSzapiro-NOAA:generic_datamode
Open

Add a shareable generic datamode#412
NickSzapiro-NOAA wants to merge 25 commits into
ESCOMP:mainfrom
NickSzapiro-NOAA:generic_datamode

Conversation

@NickSzapiro-NOAA

@NickSzapiro-NOAA NickSzapiro-NOAA commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Adds a "generic" datamode to copy user-specified variables in streams for export

Specific notes

Started by adding just to datm, as that is the intended use in UFS

For the stream_variables to be available in InitializeAdvertise, refactored shr_strdata_init_from_config into advertise (stream config) and realize (on a mesh)

Contributors other than yourself, if any: Gemini AI

CDEPS Issues Fixed (include github issue #): #411

Are there dependencies on other component PRs (if so list): N/A

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes): Adds a generic datamode, initially just to atm

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): In progress. UFS regression tests pass

Hashes used for testing: TODO

@NickSzapiro-NOAA NickSzapiro-NOAA marked this pull request as ready for review June 15, 2026 21:59
@NickSzapiro-NOAA NickSzapiro-NOAA changed the title Draft: Add a shareable generic datamode Add a shareable generic datamode Jun 15, 2026
@NickSzapiro-NOAA

Copy link
Copy Markdown
Contributor Author

This seems to be working now. One test is that it is bit-for-bit in UFS instead of "GEFS" datm datamode tests, as no variables need to be calculated/diagnosed.

I'm not sure how to test in CESM setups.
Would you be interested in testing this is in your systems @billsacks @mvertens ? Generic should work for datm cplhist, if you simply change datm_in datamode=GENERIC instead

@billsacks

Copy link
Copy Markdown
Member

Thank you for this contribution, @NickSzapiro-NOAA . I am overloaded right now so I'm not sure when I'll get a chance to review this myself.

Contributors other than yourself, if any: Gemini AI

Thank you for acknowledging the contribution of Gemini to this PR. To help determine our next steps here, can you please comment on how carefully you have reviewed and come to understand the Gemini-produced code yourself?

@NickSzapiro-NOAA

Copy link
Copy Markdown
Contributor Author

Thanks for letting me know

I would say pair programming with Gemini AI on this ended up being more trouble than it was worth, subroutine hallucinations and all. The github CI was helpful though. I am responsible for these code changes

@billsacks

Copy link
Copy Markdown
Member

I would say pair programming with Gemini AI on this ended up being more trouble than it was worth, subroutine hallucinations and all. The github CI was helpful though. I am responsible for these code changes

Okay, thanks – that's helpful to know!

I want to chat with @mvertens about this and then will get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants