Add NDCI Cyanobacteria UDP to algorithm catalog#499
Conversation
Adds the NDCI Cyanobacteria Chlorophyll-a Detection algorithm as an openEO User-Defined Process. Detects and quantifies cyanobacteria chlorophyll-a concentrations in water bodies using NDCI combined with a water-body mask and the Floating Algae Index (FAI). Based on Sentinel-2 L2A via CDSE. Conversion of the Sentinel Hub CyanoLakes evalscript (Kravitz & Matthews, 2020).
|
@emmanuelmathot if you want I can merge this one in. Do you plan on adding benchmarks in order to benefit from regression testing/performance tracking? |
|
Thx @HansVRP. What is the procedure for becnhmarking? |
Not mandatory for the merge; We do use github actions to regularly run algorithms which have included a benchmark. There we track performance to give an indication on the stability of the workflow. |
|
I also noticed a unit test failing; I would change the provided href by: https://[raw.githubusercontent.com/ESA-APEx/apex_algorithms/8d1872a/algorithm_catalog/developmentseed/ndci_cyanobacteria/openeo_udp/ndci_cyanobacteria.json instead of using the relative path |
|
Thank you @HansVRP for the review. No becnhmark planned at this stage. I'll fix the unit test. |
- Add proper schemas to all three parameters (temporal-interval, bounding-box, number) - Fix bounding_box description to be generic instead of location-specific - Remove GeoTiff from formats: save_result is hardcoded to PNG - Add trailing newline to UDP JSON
|
I believe there is a http instead of a https link within the records causing the unit tests to fail |
2 participants
Adds the NDCI Cyanobacteria Chlorophyll-a Detection algorithm as an openEO User-Defined Process. Detects and quantifies cyanobacteria chlorophyll-a concentrations in water bodies using NDCI combined with a water-body mask and the Floating Algae Index (FAI).
Based on Sentinel-2 L2A via CDSE.
Conversion of the Sentinel Hub CyanoLakes evalscript (Kravitz & Matthews, 2020).