enabled md5 checksum for object - #137
Open
vijaypdwivedi wants to merge 2 commits into
Open
Conversation
twincitiesguy
approved these changes
Aug 12, 2026
xiaoxin-ren
approved these changes
Aug 14, 2026
xiaoxin-ren
left a comment
xiaoxin-ren
left a comment
Contributor
There was a problem hiding this comment.
Please confirm no false-positive ChecksumError on encrypted/D@RE buckets for MPU, and add a test for that case.
Otherwise, looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBS04O-108: Enable Content-MD5 checksum verification for ECS S3 multipart upload parts
Summary
Added Content-MD5 checksum verification on individual uploadPart() requests. Previously, only putObject() had the VERIFY_WRITE_CHECKSUM property set, meaning ChecksumFilter would compute and verify Content-MD5 for single-part uploads but skip it for multipart upload parts. This left MPU parts without client-side integrity verification.
Changes:
S3JerseyClient.java
• Added request.property(RestUtil.PROPERTY_VERIFY_WRITE_CHECKSUM, Boolean.TRUE) in uploadPart() — enables ChecksumFilter to compute Content-MD5 for each uploaded part and verify it against the server-returned ETag
• Restored 2-arg constructor S3JerseyClient(S3Config, ConnectorProvider) for Jersey 2.x compatibility (was lost during Java 17 / Jersey 1.x → 2.x migration)
S3JerseyClientTest.java
• Added test cases for uploadPart() checksum verification -> ChecksumFilter verifies MD5 vs ETag per part