Skip to content

hide tplink sdcard default value - #1141

Merged
bmw merged 1 commit into
EFForg:mainfrom
bmw:hide-empty-default-value
Sep 4, 2026
Merged

hide tplink sdcard default value#1141
bmw merged 1 commit into
EFForg:mainfrom
bmw:hide-empty-default-value

Conversation

@bmw

@bmw bmw commented Sep 3, 2026

Copy link
Copy Markdown
Member

while reviewing #1134 i noticed that installer tplink --help looked like:

--sdcard-path <SDCARD_PATH>
  For advanced users: Specify the path of the SD card to be mounted explicitly.
  
  The default (empty string) is to use whichever sdcard path the device would use natively to mount storage on. On most TP-Link this is /media/card, but on hardware versions 9+ this is /media/sdcard
  
  Only override this when the installer does not work on your hardware version, as otherwise your custom path may conflict with the builtin storage functionality.
  
  [default: ]

i think this [default: ] looks bad and is redundant with the help text. setting this attribute removes it from the help output

Pull Request Checklist

  • The Rayhunter team has recently expressed interest in reviewing a PR for this.
    • If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
  • Added or updated any documentation as needed to support the changes in this PR.
  • Code has been linted and run through cargo fmt.
  • If any new functionality has been added, unit tests were also added.
  • CONTRIBUTING.md has been read.
  • Your pull request is fewer than ~400 lines of code.

You must check one of:

  • No generative AI (including LLMs) tools were used to create this PR.
  • Generative AI was used to create this PR. I certify that I have read and understand the code, and that all comments and descriptions were authored by myself and are not the product of generative AI.

@bmw
bmw merged commit 3d5bfa6 into EFForg:main Sep 4, 2026
24 checks passed
@bmw
bmw deleted the hide-empty-default-value branch September 4, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants