Skip to content

Deduplicate some Svelte components - #1138

Open
untitaker wants to merge 7 commits into
EFForg:mainfrom
untitaker:deduplicate-svelte-components
Open

Deduplicate some Svelte components#1138
untitaker wants to merge 7 commits into
EFForg:mainfrom
untitaker:deduplicate-svelte-components

Conversation

@untitaker

@untitaker untitaker commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Mostly pure refactor, except for

  • ClockDriftAlert. There I removed the dedicated "clock" svg and just use the default alert (!) icon
  • I noticed the config gear icon looked wonky at high-resolution. it was probably AI-slop from myself. i replaced it with a bootstrap icon
image

(the third icon is what's actually in this PR)

I'm waiting on my other PRs (#1132) to get through before un-drafting this, because there's some conflicts.

I also want to simplify the config handling for enabled analyzers, ideally we would generate the list of checkboxes from the backend, so that we can add analyzers without having to modify the frontend.

Pull Request Checklist

  • The Rayhunter team has recently expressed interest in reviewing a PR for this.
    • If not, this PR may be closed due our limited resources and need to prioritize how we spend them.
  • Added or updated any documentation as needed to support the changes in this PR.
  • Code has been linted and run through cargo fmt.
  • If any new functionality has been added, unit tests were also added.
  • CONTRIBUTING.md has been read.
  • Your pull request is fewer than ~400 lines of code.

You must check one of:

  • No generative AI (including LLMs) tools were used to create this PR.
  • Generative AI was used to create this PR. I certify that I have read and understand the code, and that all comments and descriptions were authored by myself and are not the product of generative AI.

@untitaker
untitaker marked this pull request as ready for review September 2, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant