add support for prepare_cmds in the EESSI environments - #354
Merged
Merged
Conversation
smoors
commented
Sep 8, 2026
Comment on lines
-16
to
-18
| pull_request: | ||
| branches: | ||
| - main |
Collaborator
Author
There was a problem hiding this comment.
i removed this because the scorecards checks are not designed for running on every PR. it will still run every week on the main branch.
Collaborator
|
@smoors I noticed that what I did is indeed not working. But this would also not work at UGent. Because it still requires the |
laraPPr
requested changes
Sep 11, 2026
Comment on lines
+128
to
+129
| 'source /cvmfs/software.eessi.io/2025.06/init/lmod/bash', | ||
| 'module unload EESSI', |
Collaborator
There was a problem hiding this comment.
Is this not better?
Suggested change
| 'source /cvmfs/software.eessi.io/2025.06/init/lmod/bash', | |
| 'module unload EESSI', | |
| 'module use /cvmfs/software.eessi.io/init/modules', |
laraPPr
added a commit
to laraPPr/EESSI-test-suite
that referenced
this pull request
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the config file, EESSI
prepare_cmdsreally belong in theenvironmentsinstead of thepartitions, because otherwise it would mess up the local environment.to help with this, i added the
eessi_prepare_cmdsargument toset_required_config. now i can change in the config file this:to this:
see also the companion docs PR EESSI/docs#862