Skip to content

Allow any downstream user to install stuff in the py venv - #130

Merged
mahf708 merged 1 commit into
mainfrom
bartgol/venv-folder-permissions
Nov 3, 2026
Merged

mahf708 merged 1 commit into
mainfrom
bartgol/venv-folder-permissions

Conversation

@bartgol

@bartgol bartgol commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

EKAT is failing to install cacts in CI with

ERROR: Could not install packages due to an OSError: [Errno 13] Permission denied: '/projects/e3sm/software/eamxx-venv/lib/python3.11/site-packages/cacts'
Check the permissions.

I can't be 100% sure this will fix our EKAT CI, since I need to get the PR merged, and rebuild our CI image first, but I'm quite confident (and I have a friend backing me up).

@bartgol bartgol self-assigned this Oct 30, 2026
Copilot AI balanced review requested due to automatic review settings October 30, 2026 23:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the GHCI virtual-environment permissions change.

No open issues 🎉

What changed in this PR

This PR makes the GHCI Python virtual environment writable by downstream
users, aiming to resolve EKAT CI’s permission error when installing cacts.

Changes:

  • Applies recursive 777 permissions to the virtual environment after the
    existing package installations succeed.
File Description
ghci/​env/​Dockerfile Makes the eamxx-venv directory and its contents writable by all users.

Review effort: Balanced

@bartgol
bartgol force-pushed the bartgol/venv-folder-permissions branch from 341e1ca to ee6eb96 Compare October 30, 2026 23:29
@bartgol
bartgol requested a review from mahf708 October 31, 2026 00:33

@mahf708 mahf708 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, btw, feel free to add tests for downstream stuff here (like EKAT) much like we do for e3sm-case, etc.

@bartgol
bartgol added this pull request to the merge queue Nov 2, 2026
@bartgol

bartgol commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

Looks good, btw, feel free to add tests for downstream stuff here (like EKAT) much like we do for e3sm-case, etc.

We would have to test running something as a different user, and verify all tools are ok. E.g., verify we can install stuff in the venv. If I have time, I'll do it.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 3, 2026
@mahf708
mahf708 added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit be78a18 Nov 3, 2026
43 checks passed
@mahf708
mahf708 deleted the bartgol/venv-folder-permissions branch November 3, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants