Repository navigation
Allow any downstream user to install stuff in the py venv - #130
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the GHCI virtual-environment permissions change.
No open issues 🎉
What changed in this PR
This PR makes the GHCI Python virtual environment writable by downstream
users, aiming to resolve EKAT CI’s permission error when installing cacts.
Changes:
- Applies recursive
777permissions to the virtual environment after the
existing package installations succeed.
| File | Description |
|---|---|
ghci/env/Dockerfile |
Makes the eamxx-venv directory and its contents writable by all users. |
Review effort: Balanced
341e1ca to
ee6eb96
Compare
mahf708
left a comment
There was a problem hiding this comment.
Looks good, btw, feel free to add tests for downstream stuff here (like EKAT) much like we do for e3sm-case, etc.
We would have to test running something as a different user, and verify all tools are ok. E.g., verify we can install stuff in the venv. If I have time, I'll do it. |
EKAT is failing to install cacts in CI with
I can't be 100% sure this will fix our EKAT CI, since I need to get the PR merged, and rebuild our CI image first, but I'm quite confident (and I have a friend backing me up).