Skip to content

⚡ Optimize sidecar file scanning by removing redundant glob #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DynamiteC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize sidecar file scanning by removing redundant glob #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/sidecar/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,6 @@ def run_sync_cycle():

current_cycle_files = set()

# Prune uploaded_files set to only include files that currently exist
# This prevents the set from growing indefinitely.
existing_files = {str(p) for p in root.glob("**/*.m4s")}
uploaded_files.intersection_update(existing_files)

# Use ThreadPoolExecutor to parallelize uploads
with ThreadPoolExecutor(max_workers=10) as executor:
for app_dir in root.iterdir():
Expand All @@ -83,6 +78,7 @@ def run_sync_cycle():
elif entry.name.endswith('.m4s'):
p = Path(entry.path)
segments.append(p)
# Track file for pruning uploaded_files at the end of cycle
current_cycle_files.add(str(p))

# Sort segments by name to enable binary search
Expand Down Expand Up @@ -118,6 +114,7 @@ def run_sync_cycle():
executor.submit(upload_file, segment, s3_key_seg)

# Prune uploaded_files set to only include files that currently exist
# (Using files tracked during the main loop iteration)
uploaded_files.intersection_update(current_cycle_files)

except Exception as e:
Expand Down