Repository navigation
docs(release-criteria): a fresh held-out pair stays sealed until the final 1.0 check (#408) - #1296
Merged
Merged
Conversation
…no run until the final 1.0 check, since any pair measured now fails W6 and W7 at its first measurement (#408)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A fresh held-out pair offered for W5 (#408) is pinned sealed: no Measure run fetches it until the final 1.0 check. That check is made once, when W4, W6 and W7 pass on the reference models.
Motivation
Since #1294, W5 counts a pair only if its first measurement meets W4, W6 and W7. No model meets W6 (some bodies are still boxes) or W7 (some properties are still missing). So any pair measured now fails at its first measurement and is used up.
-f holdout=trueruns measure every pair on the held-out list, and they run often. The pairs asked of contributors on 2026-10-29 would be used up on their first such run.Changes
docs/release-1.0-criteria.md, W5: the sealing rule.docs/reference-models.md, "Adding a model": the same for whoever offers a pair.No pair is sealed yet. The pin list and the Measure input for the final check come with the first sealed pair.
Testing
Docs only.