fix(elements): Revit 2008 to 2023 frames with no ElementId of their own take the id of the declared record around them, and 2016 to 2023 leave out the elements outside the export phase and in a non-primary design option (#1261) (RE-315)

README.md

@@ -89,7 +89,7 @@ Every deploy checks the viewer's privacy posture in two ways. `viewer/scripts/au
 The full list, with each gap's status and evidence, is in [`docs/evidence.md`](docs/evidence.md#what-does-not-work-yet). In brief:
 
 - Files from before Revit 2008 are not read, and 2008 to 2014 files are experimental, measured on local files only and outside the 1.0 range.
-- Revit 2015 to 2022 and 2027 projects are experimental: measured against the same models saved by a neighbouring release, not against Revit's own export (one 2015 project aside). Revit 2026 is experimental too, measured on one project.
+- Revit 2015 to 2022 and 2027 projects are experimental: measured against the same models saved by a neighbouring release, not against Revit's own export (one 2015 project, RE-198, and one 2018 project, RE-315, aside). Revit 2026 is experimental too, measured on one project.
 - On Revit 2008 to 2023, 2026 and 2027 projects an element's body is its bounding box, cut back at its joins where they are read. On 2024 and 2025 it is the box only where the bytes are not decoded: roofs by extrusion outside Revit 2025, hip roofs over a T or U footprint, monolithic spiral stair flights and straight riserless ones with a nosing, edited wall profiles, ducts and pipe fittings. From 2023, doors and windows are drawn from Revit's saved meshes where those decode whole; furniture and other loadable families stay boxes unless `--saved-meshes` is given.
 - `rvt-elements` and Python list each element's saved parameters on Revit 2023 to 2027 files, experimentally on 2015 to 2022 ones and not on 2008 to 2014, but built-in parameters have no name, a wall's or floor's type parameters are not joined to it, and only `rvt-ifc --revit-property-sets` writes the rest into IFC.
 - Family files give metadata, previews and types but no family geometry, and template files (`.rte`, `.rft`) are not measured, because no template is in any corpus.

ROADMAP.md

@@ -28,8 +28,9 @@ zero-upload browser viewer. Revit 2023 projects get a narrower version of the
 same, and Revit 2015 to 2022, 2026 and 2027 projects are experimental. Every
 recovery claim is measured against the oracle its report names: Revit's own
 IFC export of the same model wherever one is measured, and for 2015 to 2018,
-2019 to 2022 and 2027, which have no measured same-release export (except one
-2015 project, RE-198), the same
+2019 to 2022 and 2027, which have no measured same-release export (except two
+projects, BIMcollab's 2015 example, RE-198, and Vitoria's 2018 `ALD26 Before`,
+RE-315), the same
 sample projects saved by Revit
 2019, 2023 and 2026 (but 2015's `rst_basic`, another model than its 2019 copy).
 What is not decoded

changelog.d/fixed/1261-32bit-second-prologue.md

@@ -0,0 +1,34 @@
+- **A Revit 2008 to 2023 project whose element frames carry no ElementId of
+  their own now exports those elements, on their storeys (measured on one
+  Revit 2018 project).** Revit 2018's
+  `ALD26 Before` exported none of the 1,394 elements and spaces in Revit's own
+  export (#1261): most of its frames in `Partitions/0` do not open with a
+  declared `u32` ElementId, but sit inside their element's partition record, as
+  2024 and later frames do (RE-35). Those records are `u32` ElementId, `u32`
+  size, the tag of `ElementHeader`, a count, the body and a 12-byte trailer that
+  echoes the size; the 2024 walk's flag test stops at the first record with
+  another flag word, after 115 of this file's 12,626. A placed-instance frame
+  with no declared id now takes the id of the declared record around it when
+  its own reference list names that id, and so does a Level frame that is a
+  `Level` with a name block in its stream, which gives the file its 7 storeys.
+  The file now writes 1,136 of Revit's 1,321 elements by ElementId, 1,127 of
+  them in Revit's class or IFC4's for its IFC2X3 one (9 curtain walls come out
+  as walls), none that Revit's export lacks, 1,073 on Revit's storey. A curtain
+  panel frame that opens with a count rather than `ff ff ff ff` is left out,
+  since 96 of the 102 on that file are the shells of panels Revit does not
+  write. The 185 elements still missing are 178 conduits, conduit fittings and
+  gutters, whose categories are not yet recovered, 4 panel walls and 3
+  assemblies (RE-315). Files whose frames all open with their id export as
+  before.
+- **Revit 2016 to 2023 exports leave out the elements Revit's own export
+  leaves out by phase and by design option.** Only 2024 and later applied the
+  export phase (RE-184) and the primary design option (RE-40). A Revit 2018
+  project wrote 198 pipes, fittings and other elements that Revit's export does
+  not hold, and writes none now; the counts cannot say whether the phase or the
+  design options removed them, and the held-out file is not opened to find
+  out. The phase is read as RE-281 reads it. Design options are read as on 2024
+  with `u32` ids: on the `rst_basic_sample_project` of each of 2016 to 2023 the
+  one `Mass` in a non-primary option is found and counted, as the 2024 and 2025
+  copies of the model count it, and leaves the production counts of the
+  diagnostics without changing the exported IFC. Revit 2008 to 2015 keep every
+  element (RE-315).