Repository navigation
docs(readme): stop quoting a unit-suite pass count - #436
Merged
Merged
Conversation
README.md and STATUS.md quoted "921 tests" from 2026-10-27, a count that included the inline unit suites no job runs now, and STATUS.md listed the integration tests by count. A unit-suite pass count is not evidence. Both now name the targets CI runs and the command, and README.md's contributor checklist points at tools/ci/run_test_targets.sh and the ban.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55fc30933b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4 tasks done
tests/fixtures/canonical/README.md said canonical_corpus and block_names run under `cargo test`, in a step of that name. The Test job runs them through tools/ci/run_test_targets.sh, and the byte-built R14 fixtures it cited are unit tests no job runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md and STATUS.md quote "921 tests" from 2026-10-27, a count that included the inline
#[cfg(test)]suites no job runs since #428, and STATUS.md lists the integration tests by count (including two unit-classed files and a WASM count from a crate whose tests no CI job runs). A unit-suite pass count is not evidence.cargo test, and says the byte-built R14 fixtures it cited are unit tests no job runs.tools/ci/run_test_targets.sh --release --all-features; the contributor checklist names the runner and says unit tests are banned.python3 tools/maintainer/readme_status.py --checkpasses).Lands after #428 (the runner it names) and after the area deletions (#429 to #434). Held back from #428 because open PRs touch these two files.
Spec reference
Not a decoder change.
Test plan
python3 tools/maintainer/readme_status.py --checkpasses.Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the Developer Certificate of Origin 1.1. Specifically, I affirm that the contribution is my own work (or rightfully licensed to me) and that it can be distributed under the project's Apache-2.0 license.