Repository navigation
chore(ci): run every corpus-reading real target in the Corpus job - #435
Merged
Merged
Conversation
integration_dxf_roundtrip, integration_gltf and integration_legacy_container read ../../samples and skip when it is absent, which is every Test leg, and the Corpus job's list of targets did not name them, so they ran nowhere with the 19 pinned drawings in place. The step now runs all eight targets of tools/ci/test-targets.txt that read the corpus, and fails on the "convert failed" early return of integration_dxf_roundtrip as well as on a skip, since both pass vacuously.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 28, 2026
DrunkOnJava
changed the title
…iner in the Corpus job The manifest classes integration_legacy_container as real with seven tests skipped, because they build their flat files and page maps byte by byte. The Corpus step ran the file whole. It now passes the same seven names to libtest's --skip, so the manifest stays the one statement of what runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three
realtargets oftools/ci/test-targets.txt(#428) read../../samplesand skip when it is absent:integration_dxf_roundtrip(dwg-to-dxf's converter online_2013.dwg, release by release),integration_gltf(the glTF exporter on the same drawing) and the four corpus tests ofintegration_legacy_container(the R14, R2000 and R2007 object walks). Every Test leg lacks that directory, and the Corpus job's step named only five targets, so these three ran nowhere with the 19 pinned drawings in place: every one of their corpus tests returned early and passed.The step now runs all eight corpus-reading targets.
integration_legacy_containerruns without the seven byte-built tests itsskip=list in the manifest leaves out (the same seven names, passed to libtest's--skip, which is unique across the eight binaries), so the manifest stays the one statement of what runs. The guard that fails the step on the wordskippingalso fails onconvert failed, the early return ofintegration_dxf_roundtripwhen the converter errors on the drawing, which passes just as vacuously.All ten drawings these targets name (
line_R14,arc_R14,circle_R14,line_2000,arc_2000,circle_2000,line_2007,arc_2007,circle_2007,line_2013) are in the 19-file subset (testscolumn oftools/corpus/pins.tsv).Spec reference
Not a decoder change. No corpus count moves.
Test plan
block_names5,class_census1,corpus_roundtrip5,integration_dxf_roundtrip7,integration_gltf3,integration_legacy_container4 (7 filtered out),r2013_entity_values15 andsamples23 tests passed, with noskippingand noconvert failedin the log. (The first run, 40675739514, ranintegration_legacy_containerwhole, 11 tests; its macOS stable Test leg also failed once on a rustup download,static.rust-lang.orgunreachable, and passed on re-run.)Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the Developer Certificate of Origin 1.1. Specifically, I affirm that the contribution is my own work (or rightfully licensed to me) and that it can be distributed under the project's Apache-2.0 license.