Repository navigation
docs: record the table and unp decoder landings, and name the types still skipped - #424
Merged
Merged
Conversation
…till skipped CHANGELOG gains the table objects (#313, #316, #317, #319), the nineteen classes derived from AutoCAD's output (#326 to #341), the DIMENSION scorer (#387), the BLOCK fixtures (#407), the maintainer tools (#406, #383) and the merge train's stack handling (#421 to #423). README said every skipped type had a decoder in review; only SHAPE (#310) and the VIEWPORT entity header (#311) do, and the rest are twelve custom classes in the BookViewerApp3 drawings with no DXF export yet, now named. STATUS's pending section says its counts are the 2026-08-30 snapshot.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs only:
jev_review.pyand the AutoCAD trial tooling (feat(tools): rank the prose and open issues that merged pull requests may have overtaken #406, feat(tools): scripts and runbook for the AutoCAD trial (#119, #348, #375) #383);Evidence
tools/corpus/baseline.tsvat each landing: 379 skipped before feat(objects): decode TABLESTYLE from R2010 and CELLSTYLEMAP (§20.4.101.2, §20.4.102, #151) #313, 44 after feat(objects): decode ACSH_EXTRUSION_CLASS from AutoCAD's own DWG and DXF output (#152) #341, 0 errored throughout.corpus-measurementartifact of CI run 40655020787 (feat(objects): decode ACSH_EXTRUSION_CLASS from AutoCAD's own DWG and DXF output (#152) #341's head).readme_status.py --checkpasses.jev_review.py prosewas run on the edited documents. It caught an overbroad "ACDBASSOC*" in the first draft (feat(objects): decode ACDBASSOCPERSSUBENTMANAGER and ACDBPERSSUBENTMANAGER from AutoCAD's own DWG and DXF output (#152) #379 decodes ACDBASSOCPERSSUBENTMANAGER); the classes are now named one by one.Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
CLEANROOM.md.See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the
Developer Certificate of Origin 1.1.
Specifically, I affirm that the contribution is my own work (or rightfully
licensed to me) and that it can be distributed under the project's Apache-2.0
license.
I will sign off commits with
git commit -swhen asked, which adds aSigned-off-bytrailer to the commit message asserting the DCO.