Repository navigation
Open
Labels
area:ciCI workflowsCI workflowspriority:P2Quality and completenessQuality and completenesstype:testFixtures, corpus checks, oracles and gatesFixtures, corpus checks, oracles and gates
Description
Scope
dwg-rs adopted the rvt-rs model on 2026-10-28, which:
- bans unit tests;
- has CI run only the real, contract and hardening targets of
tools/ci/test-targets.txt(chore(ci): class every tests/ target and run all but the unit ones #428); - deletes the inline
#[cfg(test)]suites area by area (test(exporters): delete the exporters' and geometry inline mirror suites, 4,146 lines #429 to test(tables): delete the symbol-table decoders' inline mirror suites, 375 lines #434).
That work showed where the deleted suites had been the only check. Those places need an end-to-end check through the real entry point, or a decision that none is needed.
- SVG exporter. Nothing runs it on a drawing.
integration_svg_goldenspins synthetic documents and is classedunit. It needs a real target that exports pinned drawings and checks the output, or adwg-convertCLI target. handle_allocator. It has no caller outside the deleted tests. Decide between wiring it into the writer and deleting it.- Decoders for types the pinned corpus does not hold. These include POLYLINE_2D, POLYLINE_MESH and VERTEX variants, OLE2FRAME, and the other types STATUS.md lists as wired but unexercised. They are now checked only by compiling. They need records, from AutoCAD trial drawings (Unprinted classes: decoded from one drawing each; provisional until controlled AutoCAD drawings #348) or other public pins.
limitsandapibookkeeping.ParseLimitsandWalkerLimitsare no longer exercised by a test. A hardening target should feed over-limit inputs through the public API, in the same way One ParseLimits with every cap #185 calls for every cap.wasm/. Its 10 files of inline tests run in no CI job. Delete them under the same model, or replace them with awasm-packend-to-end run of the viewer API on a pinned drawing.- The
cliclass is empty. None of the seven binaries is driven end to end by a target.
Remaining inline suites
41 src files still hold suites:
- 36 are held back because open PRs touch them: the R13 stack (feat(container): open and walk AC1012 (R13), pinned on 22 real drawings (#119) #323, feat(objects): R13 and R14 reference closure from the RL inside the common data (#84), stacked on #323 #324, fix(entities): R13 takes the R13-R14 branch of TEXT, VIEWPORT, TRACE, DIMSTYLE and LEADER (#119) #355, docs: the record types three R13 sets hold, and the ones still unmeasured (#119) #356, feat(entities): route MINSERT (8) and decode §20.4.10's grid fields (#141) #410, feat(corpus): pin the 122 US Forest Service AC1012 drawings by Wayback URL (#345) #412) and feat(entities): decode SHAPE from §20.4.37 (#140) #310/feat(objects): decode VIEWPORT ENTITY HEADER from §20.4.70 (#146) #311.
- Four objects' styles are kept until
objects/modern.rsloses its test-only helpers (see test(objects): delete the object decoders' inline mirror suites, 1,021 lines #433). string_stream.rsgoes last, because other suites import its tests module.
Acceptance
- Each gap above has an end-to-end target or a recorded decision
- No
#[cfg(test)]remains undersrc/orwasm/src/ -
tools/ci/test-targets.txtclasses every target, withclipopulated
Parent: #184
Metadata
Metadata
Assignees
Labels
area:ciCI workflowsCI workflowspriority:P2Quality and completenessQuality and completenesstype:testFixtures, corpus checks, oracles and gatesFixtures, corpus checks, oracles and gates
Activity