Skip to content

End-to-end checks the deleted unit suites leave uncovered, and the inline suites still to delete #438

Open

Description

@DrunkOnJava

Scope

dwg-rs adopted the rvt-rs model on 2026-10-28, which:

That work showed where the deleted suites had been the only check. Those places need an end-to-end check through the real entry point, or a decision that none is needed.

  • SVG exporter. Nothing runs it on a drawing. integration_svg_goldens pins synthetic documents and is classed unit. It needs a real target that exports pinned drawings and checks the output, or a dwg-convert CLI target.
  • handle_allocator. It has no caller outside the deleted tests. Decide between wiring it into the writer and deleting it.
  • Decoders for types the pinned corpus does not hold. These include POLYLINE_2D, POLYLINE_MESH and VERTEX variants, OLE2FRAME, and the other types STATUS.md lists as wired but unexercised. They are now checked only by compiling. They need records, from AutoCAD trial drawings (Unprinted classes: decoded from one drawing each; provisional until controlled AutoCAD drawings #348) or other public pins.
  • limits and api bookkeeping. ParseLimits and WalkerLimits are no longer exercised by a test. A hardening target should feed over-limit inputs through the public API, in the same way One ParseLimits with every cap #185 calls for every cap.
  • wasm/. Its 10 files of inline tests run in no CI job. Delete them under the same model, or replace them with a wasm-pack end-to-end run of the viewer API on a pinned drawing.
  • The cli class is empty. None of the seven binaries is driven end to end by a target.

Remaining inline suites

41 src files still hold suites:

Acceptance

  • Each gap above has an end-to-end target or a recorded decision
  • No #[cfg(test)] remains under src/ or wasm/src/
  • tools/ci/test-targets.txt classes every target, with cli populated

Parent: #184

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI workflowspriority:P2Quality and completenesstype:testFixtures, corpus checks, oracles and gates

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions