Repository navigation
Close the NuGet isolation review findings - #19
Merged
Merged
Conversation
A run's folder gets its name only with the marker inside, and the sweep skips a marker without a pid. A shared folder that holds a kit package is refused. A kit prefix matches on id boundaries. A package that cannot be saved and a folder that cannot be removed are reported and left to the next run. The docs say what the guard cannot see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18: seven review points checked against
tests/nuget-isolation.sh.DragoAnt.MSBuildKitmatches itself andDragoAnt.MSBuildKit.X, notDragoAnt.MSBuildKitFoo; used by the snapshot, the harvest and the new refusal.NOTE; a folder that cannot be removed is retried three times, reported and left to the next run's sweep. Neither fails the run.Did not need a fix, now covered by checks: the machine's folder behind a junction/symlink or its 8.3 name was already refused (
pwd -Presolves both); the script stops no process and clears no machine-wide cache.tests/nuget-isolation.test.sh: 35 checks (was 23), new ones committed red first.