Repository navigation
Declare every code as a BuildDiagnosticDescriptor item - #17
Merged
Merged
Conversation
- docs-check: every reported code has exactly one BuildDiagnosticDescriptor item in the part that reports it, with the title, family, severity and opening sentence of its codes.md section and the text of its task - tests/docs.sh: a broken catalog must fail on each planted fault - tests/codes.sh: the items reach an evaluated project, each defined by its own part's file
- one diagnostic.descriptors.props per part that reports a code, imported by the part's init.props; PackageAsProj gets an init.props for it - codes.md: each section opens with the code's title, and the PKG001-019 sections name their severity
- docs/reference/diagnostic-catalog.md: the item, where the files live, how to add your own, why both sides stay hand-written - property reference row, changelog, contributing checklist - tests/codes.sh: normalise Windows paths in the evaluated items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildDiagnosticDescriptoritem (Title,MessageFormat,Description,Category,DefaultSeverity,HelpLink) in its owndiagnostic.descriptors.props, imported by the part'sinit.props: 58 codes in 6 parts.PackageAsProjgets aninit.propsfor it.docs/reference/codes.md: each section opens with the code's title;PKG001-PKG019name their severity. New pagedocs/reference/diagnostic-catalog.md.tools/docs-check.shholds the items, the<Warning>/<Error>tasks andcodes.mdtogether (both stay hand-written; the page says why) and gains--list descriptors.DefiningProjectFullPath.VER003has no item.manager/.toolkitis not refreshed: no test compares it, and it already differs fromkit/onmain.