Repository navigation
mskit-manager: package model, selection, kit.json and manifest (S2a) - #16
Merged
Merged
Conversation
- mskit.package.json, catalog.json and filter.json (schema 1), strict reads - Selection: core -> company -> team -> repository, required, locked, requires - kit.json schema 2 plus the schema-1 reader that keeps multi-line parts - manifest.json, sorted and LF-only, byte-stable round trip; KitLayout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice S2a of
mskit-manager: the package model the install flow will use. No command uses it yet; no I/O beyond parsing documents.Packages/: readers formskit.package.json, the trunk'smskit/catalog.jsonand a company or teammskit/filter.json(schema 1, strict: unknown fields, schemas, tiers, kinds and version ranges are errors).Packages/Selection: core defaults → company filter → team filter → repositorykit.json, a later layer winning per part; required parts never disabled; company-locked parts refused for team and repository with the layer named;requiresclosed transitively; unknown parts, two company/team filters and a team filter not extending the attached company are errors.PartDecisioncarries the--explaindata.Install/KitJson: schema 2, plus the schema-1 reader forupdate.sh's file, which keeps a multi-linepartsarray (audit D3).Install/Manifest: sorted, LF-only, byte-stable round trip.Install/KitLayout: the only place that knows the folder and file names.NuGet.Versioning(MIT) for filter version ranges.Evidence
Red first: the test project did not compile before the types existed. Rules toggled off, failing tests per TFM: locked 4, required 3, requires closure 2, schema-1 reader 6, manifest sort 1.
update.sh'sjson_partsreturns[]on the multi-line fixture that the new reader parses into three parts.sh tests/manager.sh: 300 tests passed (net8.0 + net10.0).