Repository navigation
Add MSKit_DefaultPackageIconUrl next to the kit's icon - #14
Merged
Merged
Conversation
- iconUrl only with the kit's embedded icon, never with the project's own PackageIcon or an empty property; MSKITPKG008 only for a project-set PackageIconUrl
- package.targets writes it as PackageIconUrl only when the kit's own icon is packed and the project set no PackageIconUrl - MSKITPKG008 skips the kit-set URL, still reports a project-set one
- property row, the icon line in packaging, the MSKITPKG008 section, the owner-layer note and an Unreleased changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSKit_DefaultPackageIconUrl(empty by default): when the kit packs its own icon, the URL is also written asPackageIconUrl, so clients that predate embedded icons show it; nuget.org keeps the embedded one. Never applied when the project setsPackageIconorPackageIconUrl.MSKITPKG008now reports only aPackageIconUrlthe project sets itself; same code and HelpLink.MSKITPKG008section, owner-layer note, changelog.Tests
tests/package-icon.sh: kit icon + URL →iconUrlset, noMSKITPKG008, noNU5048; ownPackageIcon+ URL → noiconUrl; empty → noiconUrl; projectPackageIconUrl→ kept andMSKITPKG008fires. Red on main (1 failure), green after; dropping either new condition fails 2 cases.