Repository navigation
Pack the package icon under its own extension, accept JPEG - #11
Merged
Merged
Conversation
A JPEG PackageIconPath fails the pack with NU5046 today: the kit packs it as icon.png.
A JPEG PackageIconPath was packed as icon.png and failed the pack with NU5046. The icon is now packed as icon.<extension>, lowercased, and the nuspec names that file. nuget.org accepts PNG and JPEG, so MSKIT_PKG015 reads a JPEG's size too and reports the format it found.
vfofanov
marked this pull request as ready for review
October 6, 2026 06:51
The icon lines move from the README to docs/packaging.md and the reference pages; run.sh keeps both new test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
icon.<extension>, lowercased (icon.png,icon.jpg); the nuspec names the same file. A JPEGPackageIconPathno longer fails the pack with NU5046.MSKIT_PKG015accepts a 128×128 PNG or JPEG (nuget.org accepts both) and reads a JPEG's size; the message names the format it found.PackageIconthe project sets is kept (already guarded; now covered by a test).tests/package-icon.shwith thePackageIconfixture — default PNG, JPEG, a wrong-size JPEG, an upper-case.PNG, a project's own icon.Verification
icon$(ext).sh tests/run.shgreen locally.