feat: reject page sizes above the maximum - #12
Merged
Merged
Conversation
The request-driven PaginateAsync overloads throw BadHttpRequestException when request.PageSize exceeds maxPageSize, replacing the silent clamp. The fluent builder's MaxPageSize and ExecutionOptions keep their clamp. Bump the version to 3.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The request-driven
PaginateAsyncoverloads reject arequest.PageSizeabovemaxPageSizewithBadHttpRequestException(status 400), replacing the silentclamp. JSON:API cursor pagination profile: "If
page[size]exceeds theserver-defined max page size, the server MUST respond according to the rules
for the max page size exceeded error."
Behavior
pageSizewithinmaxPageSizepageSizeabovemaxPageSizemaxPageSize, 200The fluent builder's
MaxPageSizeandExecutionOptions.MaxPageSizekeeptheir documented developer-facing clamp; core is unchanged.
Breaking
Requests with an oversized
pageSizepreviously returned a clamped 200 pageand now return 400. Version bumped to 3.2.0.