feat: reject invalid pagination request parameters - #11
Merged
Merged
Conversation
The AspNetCore registry entry points (Keyset(registry, request) and the PaginateAsync overloads) throw BadHttpRequestException for an unknown sortBy or an unsupported sortDir, and PaginateAsync converts invalid cursors and non-positive page sizes to BadHttpRequestException. ArgumentNullException passes through as a developer error. PaginationSortRegistry.TryResolve returns false for an unsupported direction; Resolve keeps its fallback. Remove unreachable null guards, inline single-caller private methods, update packages, and bump the version to 3.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The AspNetCore integration rejects invalid pagination request parameters with
BadHttpRequestException(status 400), which ASP.NET Core's exception handlermiddleware maps to the response. The core package is unchanged and framework-agnostic.
Behavior
sortBysortDiroutside empty/asc/descArgumentException(500)pageSizezero or negativeArgumentOutOfRangeException(500)ArgumentNullExceptionfrom developer errorPaginationSortRegistry.TryResolvereturnsfalsefor an unsupported direction.Resolvekeeps its fallback for consumers that want lenient semantics.Breaking
ArgumentExceptionfrom the AspNetCorePaginateAsyncoverloads now receive
BadHttpRequestException.TryResolvereturnsfalsewhere an unsupportedsortDirpreviouslyresolved ascending.
Cleanup
[MethodImpl]hot/cold splits,throw helpers, and field initializers kept.
Microsoft.CodeAnalysis.CSharpcapped at 5.6.0 by theSDK compiler. Version bumped to 3.1.0.
api-reference.md,patterns.md,prebuilt-definitions.md.