Update rules for YAML files - #20
Open
deorus wants to merge 1 commit into
Open
Conversation
artyom
approved these changes
Feb 2, 2023
henningmu
approved these changes
Feb 23, 2023
henningmu
left a comment
henningmu
left a comment
There was a problem hiding this comment.
I'm not a big fan of having exceptions for YAML. However, since this is purely stylistic and fully automated during development (format on save and precommit), I'm fine with merging this. More joyful collaboration and contributions from Infrastructure are definitely a win that trumps my personal preference 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may not be consensual but as an Infrastructure engineer I spend some hours behind YAML. 4 spaces make it harder to read IMO. The single quotes is more of a personal choice.
This PR is a proposal, let me know if there's any major pushback.