fix(packs): uninstall 受保护中止 + DRY 回收站策略 - #72
Merged
Tanya7z merged 2 commits intoJul 24, 2026
Conversation
- Abort packs uninstall for platform packs before paired RP / binding side effects (LSP) - Structure uninstall outcomes separately from CLI formatting (DIP) - Centralize DEFAULT_PACK_UNINSTALL + resolveUninstallTrashDir (DRY/OCP) - Tighten uninstallInstalledPack result type (remove unused ok/reason) - Drop accidental root module-lock.json; ignore it going forward - Cover trash/purge/missing + protected-folder contracts with tests Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 24, 2026 17:24
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packs uninstall对sfmc-modules/sfmc-modules-rp在碰配对 RP /removeBinding之前中止，避免「拒绝卸载」仍清绑定。uninstallInstalledPack去掉虚设ok/reason。DEFAULT_PACK_UNINSTALL+resolveUninstallTrashDir收拢 purge/recycleBin/默认路径。module-lock.json，并 ignore/module-lock.json。审查（本轮 push）
packs/_trash/ recycle 判定多处手写module-lock.json误提交ootb@8bb9590：success
30111027398（本轮无 wf 红）。Test plan
npm run build -w @sfmc-bds/sdk -w @sfmc-bds/bds-tools -w @sfmc-bds/cli -w @sfmc-bds/db-servercd bds-tools && node --test world-packs.test.mjs（7 pass）cd sfmc && node --test pack-update-config.test.mjs pack-update-policy.test.mjs terminal-progress.test.mjs world-packs-uninstall.test.mjs（20 pass）node --test db-server/dist/runtime.test.js（13 pass）