fix(pack): catalog 缺失时凭磁盘 manifest 卸过期 BP/RP - #45
Merged
Tanya7z merged 1 commit intoJul 23, 2026
Conversation
审查 #44 合入后的残留: - BLOCKER: deploy-catalog 缺失时 clear-rp 只删目录不卸世界清单 → collectDeployedPackUuids 同时读 catalog + 磁盘 manifest - MAJOR DRY: spawnWorldPack / readWorldPackList 统一清单读写 - MAJOR Demeter: cmdPackList 改走 list-packs CLI - 回归: list-packs + 无 catalog 卸装路径 (bds-tools 7/7) Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 23, 2026 11:15
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
审查
main@5eff389（合入 #44）后的 SOLID/正确性残留，直接补丁。ootb CI 绿，但 #44 的过期卸装路径在 deploy-catalog 缺失 时仍不完整：
BLOCKER
previous = readDeployedCatalogalone：升级前无 catalog、或 catalog 文件丢失时，--clear-rp只删世界内 RP 目录，不从world_resource_packs.json卸旧 UUIDcollectDeployedPackUuids在 deploy/clear 之前同时采集 catalog + 磁盘 BP/RPmanifest.jsonuuid，再 disable 与 desired 不一致的项MAJOR
spawnWorldPack统一 enable/disable argv；readWorldPackList成为清单读写单一权威（has-pack/editWorldPackList/ 新list-packs）cmdPackList不再直接解析world_*_packs.json，改走list-packsCLITests
bds-tools7/7（含 list-packs + 无 catalog 卸装回归）Review principles
DRY · OCP · DIP · LSP · Law of Demeter
Test plan
npm run build -w @sfmc-bds/sdk -w @sfmc-bds/bds-tools -w @sfmc-bds/clinpm test -w @sfmc-bds/bds-toolssfmc-deploy-catalog.json后sfmc pack deploy（无 RP）→ 确认旧 RP uuid 从world_resource_packs.json消失