Skip to content

Add stock, ETF, and crypto glossary page - #83

Merged
danieldanielecki merged 2 commits into
mainfrom
cursor/glossary-page-65d1
Sep 28, 2026
Merged

danieldanielecki merged 2 commits into
mainfrom
cursor/glossary-page-65d1

Conversation

@danieldanielecki

Copy link
Copy Markdown
Member

Summary

Closes #82.

  • Adds a Glossary reference page at /glossary with plain-language definitions for stocks, ETFs, crypto, and in-app analysis tools (screener, heatmaps, RSI, MACD, Fear & Greed, calendars, etc.).
  • Links Glossary from the footer Resources menu (FOOTER_RESOURCES in lib/footer-content.ts).
  • Registers the route in pathnameToNavId for consistent nav highlighting behavior on resource pages.

Verification

  • Unit tests: glossary-content, GlossaryPage, footer accessibility link.
  • Manual browser check: footer link → page load; readable in light and dark themes.

Assumptions

  • Issue body only specified “stock, etf, crypto related terms”; analysis/tooling terms were included because they match how the app explains markets elsewhere (Compare hub, tooltips).
  • Glossary is a content page, not a LegalPlaceholderPage like Copyrights/Sitemap.
  • PUBLIC_ROUTES / XML sitemap were left unchanged (legal-style routes are not listed there today).
Open in Web Open in Cursor 

cursoragent and others added 2 commits September 27, 2026 19:20
Implements issue #82 with a reference glossary at /glossary, footer
Resources link, and unit tests for content and accessibility.

Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>
Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>
@cursor
cursor Bot deployed to Preview September 27, 2026 19:25 Active
@github-actions

Copy link
Copy Markdown

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-2bwp6c970-ditectrevs-projects.vercel.app


This comment was automatically generated by GitHub Actions

@danieldanielecki danieldanielecki left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works good enough for MVP to go to prod

@danieldanielecki
danieldanielecki marked this pull request as ready for review September 28, 2026 18:15
@danieldanielecki
danieldanielecki merged commit 780cf3e into main Sep 28, 2026
10 of 11 checks passed

This branch was successfully deployed

1 active deployment
Preview — acda8761 Deployed Sep 27, 2026 by cursor[bot] via Deploy to Vercel #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossary

2 participants