Add AI stock rankings page with subscription gating by danieldanielecki · Pull Request #80 · Ditectrev/Open-Source-Stock-Application

danieldanielecki · 2026-09-15T16:02:13Z

Follow-up: ETF / Crypto ranking still failing after `1862f8f`

Root cause (remaining filter): Commit 1862f8f routed ETF and crypto enrichment through yahooFinanceService.getSymbolQuote only, while stocks still used marketDataService.getSymbolData (Finnhub when configured, then Yahoo). On preview/production with FINNHUB_API_KEY, stock rankings could enrich successfully; ETF/crypto candidates were dropped when Yahoo quote failed, falling below the minimum of 4 buy/sell rows and surfacing the insufficient-candidates error.

Fix (516db53):

Quote all categories via marketDataService.getSymbolData → Yahoo → synthetic fallback quote (same resilience pattern as AI prediction snapshots).
Relaxed crypto symbol normalization for Yahoo-style tickers (e.g. UNI7083-USD).
Ensure ranking validation errors (AI did not return… / AI returned an incomplete…) pass through userFacingApiError.

API proof (vitest route integration — real handlers, live enrichment):

GET ?category=etf → 200, buy=5, sell=5
GET ?category=crypto → 200, buy=5, sell=5
POST local-Ollama validation path for etf, crypto, stock → 200, buy/sell ≥ 4 each

Introduce /ai-rankings with short, medium, and long horizon tabs. Each ranked stock includes AI rationale validated against live market data. Reuse existing AI tier checks, SubscriptionGate, and local Ollama patterns. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-15T16:07:00Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-7jkhjopv7-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Move page and API paths, add MAIN_NAV entry, redirect /ai-rankings, and update user-facing copy and titles to Ranking. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-16T16:16:42Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-k5htib58r-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Show rank, symbol, name, and why in a readable table with horizontal scroll on narrow viewports. Keeps timeframe tabs and subscription gating. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-16T17:14:39Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-r70uj4mss-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Keep MAIN_NAV to Home, News, Ranking, and Pricing. Move Sectors, Calendars, Heatmaps, and Screener to a footer Tools section. Add Resources legal placeholders, Ditectrev contact details, social links, and dynamic copyright. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-17T08:49:47Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-qcqbem5bj-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

- Bring back react-github-btn star widget above footer content - Replace social text links with SVG icons (aria-label preserved) - Uppercase TOOLS/RESOURCES headings; keep link labels title case - Center-align the tools heading and link column Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-17T12:33:48Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-hvi8ykroq-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

- Raise contrast on ranking tabs, meta lines, table text, and footer - Split ranking into buy and sell candidate lists with separate scoring - Show side-by-side tables with stock-of-the-day accent styling - Update AI prompt, API, and types for buyCandidates/sellCandidates Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-17T12:55:35Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-fb8hzknqw-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

- Code-split Footer and render it via LazySection below the fold - Load GitHub star widget only when its slot enters the viewport - Move footer top margin to the LazySection wrapper - Ignore local Lighthouse CI artifacts Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-17T13:32:35Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-jmiifyui5-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

- Reuse HeatmapNavigation categories: etf, crypto, stock - Category-aware AI prompts, parsing, API, and enrichment - Heatmap-style category switcher on /ranking with per-category fetch Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-18T14:01:17Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-adw7pt6c8-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Route category through enrichRankingCandidates, quote ETFs/crypto via Yahoo instead of Finnhub stock paths, and tolerate missing forecast/ indicator data like AI predictions. Use category-aware insufficient- candidate error messages. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-24T15:43:53Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-izpb4tbcx-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Use marketDataService (Finnhub + Yahoo fallback) for all ranking categories instead of Yahoo-only quotes for ETF/crypto, which failed on preview while stocks used Finnhub. Add quote fallbacks and relax crypto symbol parsing. Pass ranking validation errors through the API error helper and add route integration tests for GET/POST ranking. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

Next.js type-checks vitest.config.ts during build; environmentMatchGlobs is not in this Vitest InlineConfig type. Node ranking integration tests still use per-file @vitest-environment node and the guarded setup file. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

github-actions · 2026-09-25T17:46:36Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-qruzayxwi-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

cursor

Stale Bugbot comment from a previous run.

- Fix sell rankings inverting timeframe scores by applying direction multiplier to timeframe-specific adjustments (momentum, sentiment, runway, target upside) - Fix stale ranking fetches overwriting newer results by adding cancellation flag to useEffect

github-actions · 2026-09-25T18:03:59Z

Mistral code review

Correctness

Footer.tsx: The footer component now includes a comprehensive set of links and contact information, which is a good addition. However, ensure that all links are correctly formatted and point to the right destinations.
HomeHub.tsx: The AI outlook section now includes links to the Stock of the day and Ranking pages, which is a good improvement for navigation.
LegalPlaceholderPage.tsx: This new component is a good addition for legal pages, but ensure that the content is correctly displayed and styled.
AIStockRankingsPanel.tsx: This new component is a good addition for displaying AI stock rankings. However, ensure that the data is correctly fetched and displayed.
ranking-api-get.integration.test.ts: This new test file is a good addition for testing the GET API endpoint for stock rankings. However, ensure that the test cases cover all scenarios.
ranking-api.integration.test.ts: This new test file is a good addition for testing the POST API endpoint for stock rankings. However, ensure that the test cases cover all scenarios.

Edge Cases

Footer.tsx: Ensure that the footer component handles edge cases such as missing links or contact information gracefully.
HomeHub.tsx: Ensure that the AI outlook section handles edge cases such as missing data or links gracefully.
LegalPlaceholderPage.tsx: Ensure that the legal placeholder page handles edge cases such as missing content gracefully.
AIStockRankingsPanel.tsx: Ensure that the AI stock rankings panel handles edge cases such as missing data or errors gracefully.
ranking-api-get.integration.test.ts: Ensure that the test cases cover edge cases such as invalid inputs or missing data.
ranking-api.integration.test.ts: Ensure that the test cases cover edge cases such as invalid inputs or missing data.

Security

Footer.tsx: Ensure that all links in the footer are secure and do not pose any security risks.
HomeHub.tsx: Ensure that all links in the AI outlook section are secure and do not pose any security risks.
LegalPlaceholderPage.tsx: Ensure that the legal placeholder page does not expose any sensitive information.
AIStockRankingsPanel.tsx: Ensure that the AI stock rankings panel does not expose any sensitive information.
ranking-api-get.integration.test.ts: Ensure that the test cases do not expose any sensitive information.
ranking-api.integration.test.ts: Ensure that the test cases do not expose any sensitive information.

Performance

Footer.tsx: Ensure that the footer component does not impact the overall performance of the application.
HomeHub.tsx: Ensure that the AI outlook section does not impact the overall performance of the application.
LegalPlaceholderPage.tsx: Ensure that the legal placeholder page does not impact the overall performance of the application.
AIStockRankingsPanel.tsx: Ensure that the AI stock rankings panel does not impact the overall performance of the application.
ranking-api-get.integration.test.ts: Ensure that the test cases do not impact the overall performance of the application.
ranking-api.integration.test.ts: Ensure that the test cases do not impact the overall performance of the application.

Maintainability

Footer.tsx: Ensure that the footer component is well-documented and easy to maintain.
HomeHub.tsx: Ensure that the AI outlook section is well-documented and easy to maintain.
LegalPlaceholderPage.tsx: Ensure that the legal placeholder page is well-documented and easy to maintain.
AIStockRankingsPanel.tsx: Ensure that the AI stock rankings panel is well-documented and easy to maintain.
ranking-api-get.integration.test.ts: Ensure that the test cases are well-documented and easy to maintain.
ranking-api.integration.test.ts: Ensure that the test cases are well-documented and easy to maintain.

Overall, the changes look good and address the requirements. Ensure that all edge cases are covered and the code is well-documented for maintainability.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Loading spinner stuck after access loss
- Added setLoading(false) before the early return when hasAIAccess is false to properly clear the loading state when access is lost during an in-flight request.

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 5f82ac1. Configure here.}

github-actions · 2026-09-25T18:07:33Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-avycs2wkh-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

Clear loading state when hasAIAccess becomes false to prevent the spinner from getting stuck when access is lost during an in-flight ranking request.

github-actions · 2026-09-25T18:12:06Z

🚀 Vercel Preview Deployment Ready!

Preview: https://stock-46tiyt0y9-ditectrevs-projects.vercel.app

This comment was automatically generated by GitHub Actions

cursoragent and others added 2 commits September 15, 2026 16:01

Fix Prettier formatting for AI rankings files

3e17601

Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

cursor Bot deployed to Preview September 15, 2026 16:05 Active

Rename AI rankings to Ranking at /ranking

5055077

Move page and API paths, add MAIN_NAV entry, redirect /ai-rankings, and update user-facing copy and titles to Ranking. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

cursor Bot deployed to Preview September 16, 2026 16:14 Active

Replace Ranking cards with screener-style table

401569d

Show rank, symbol, name, and why in a readable table with horizontal scroll on narrow viewports. Keeps timeframe tabs and subscription gating. Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

cursor Bot deployed to Preview September 16, 2026 17:12 Active

cursor Bot deployed to Preview September 17, 2026 08:48 Active

cursor Bot deployed to Preview September 17, 2026 12:32 Active

cursoragent and others added 2 commits September 17, 2026 12:51

Update ranking page SEO copy for buy/sell lists

6114cc1

Co-authored-by: ✅ Daniel Danielecki <danieldanielecki@users.noreply.github.com>

cursor Bot deployed to Preview September 17, 2026 12:53 Active

cursor Bot deployed to Preview September 17, 2026 13:30 Active

cursor Bot deployed to Preview September 18, 2026 13:58 Active

cursor Bot deployed to Preview September 24, 2026 15:42 Active

cursor Bot had a problem deploying to Preview September 25, 2026 17:39 Failure

cursor Bot deployed to Preview September 25, 2026 17:44 Active

danieldanielecki marked this pull request as ready for review September 25, 2026 17:54

cursor Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread services/ai-market-insights.service.ts Outdated

Comment thread app/(main)/ranking/page.tsx

cursor Bot deployed to Preview September 25, 2026 18:05 Active

cursor Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread app/(main)/ranking/page.tsx

Fix loading spinner stuck after access loss

1e03cb3

Clear loading state when hasAIAccess becomes false to prevent the spinner from getting stuck when access is lost during an in-flight ranking request.

cursor Bot deployed to Preview September 25, 2026 18:09 Active

danieldanielecki closed this Sep 25, 2026

danieldanielecki reopened this Sep 25, 2026

danieldanielecki merged commit ae33639 into main Sep 25, 2026
15 of 16 checks passed

danieldanielecki deleted the cursor/ai-stock-rankings-6c91 branch September 25, 2026 18:58

danieldanielecki had a problem deploying to Preview September 25, 2026 18:58 — with GitHub Actions Failure

danieldanielecki mentioned this pull request Sep 25, 2026

Ranking #79

Closed

Conversation

danieldanielecki commented Sep 15, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Follow-up: ETF / Crypto ranking still failing after 1862f8f

Uh oh!

github-actions Bot commented Sep 15, 2026

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

github-actions Bot commented Sep 16, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 18, 2026

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mistral code review

Correctness

Edge Cases

Security

Performance

Maintainability

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danieldanielecki commented Sep 15, 2026 •

edited by cursor Bot

Loading

Follow-up: ETF / Crypto ranking still failing after `1862f8f`

cursor Bot left a comment •

edited

Loading

github-actions Bot commented Sep 25, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading