Repository navigation
Add Job.localExec() that runs the bifrost2 job setup - #52
Draft
dan-distributive wants to merge 1 commit into
Draft
dan-distributive wants to merge 1 commit into
dan-distributive wants to merge 1 commit into
Conversation
localExec() fell through to the JS method, skipping _before_exec(), so the pyodide work function was never wrapped. It now mirrors exec(), and a rejected localExec() promise raises instead of leaving the caller waiting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
job.localExec()fell through to the JSlocalExec(), skipping_before_exec(), so the Pyodide work function was never wrapped and every slice would fail (found in #49). It now mirrorsexec():job.localExec(cores=1, *args)thenjob.wait(), plusjob.aio.localExec. A rejectedlocalExec()promise raises instead of leaving the caller waiting.End-to-end
localExec()under PythonMonkey also needs:structuredClone()global) in a releaseTested: the 35 existing tests pass; with today's dcp-client,
localExec()runs_before_exec()(work function wrapped) and raises dcp-client's "localExec is not supported on this platform" within a second.🤖 Generated with Claude Code