Improve speed of Page Sep Fixup - #1911
Merged
windymilla merged 1 commit intoJul 31, 2026
Merged
Conversation
Remove some time-consuming stuff at the cost of slightly more complex code, but worthwhile. Also, show "Working" label while working.
srjfoo
approved these changes
Jul 31, 2026
Collaborator
Author
Yes - it was taking extra long on longer files, probably proportional to the square of the number of pages, because the code was written in a simple way. Since performance has now shown itself to be a problem, I found 2 or 3 changes to make it more efficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some time-consuming stuff at the cost of slightly more complex code, but worthwhile.
Also, show "Working" label while working.