Improve ppcomp expanded output over line breaks - #1910
Merged
windymilla merged 1 commit intoAug 1, 2026
Merged
Conversation
Previously, in expanded mode, all the extra text was reported on one line of the dialog, until the line number in "File 1" changed. Now, when an addition in "File 2" is being reported, if the addition crosses a line break, that is reflected in the report.
Collaborator
Author
|
Test file: eyesthatcannotsee.zip
In each case, compare the PPcomp output with The edits made should not affect "Compact" display mode, so you don't need to check all of the above in "Compact" as well as "Expanded". However, you may want to check "Compact" for the case where the above is very different between Screenshots of different display (branch first, then
.
. Annotated version of first screenshot ("Newline from File 2" labels mark the change in this branch):
|
srjfoo
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Previously, in expanded mode, all the extra text was reported on one line of the dialog, until the line number in "File 1" changed. Now, when an addition in "File 2" is being reported, if the addition crosses a line break, that is reflected in the report.
Also, if a character is inserted at the start of a line, it should be displayed at the start of a line, rather than the end of the previous line. Note that "File 1" still mostly controls where line breaks are displayed - it's only where there's an insert in "File 2" that its line breaks are taken into account.