Open
Conversation
elguero
suggested changes
Apr 19, 2026
Contributor
elguero
left a comment
elguero
left a comment
There was a problem hiding this comment.
This PR needs to be brought up to date with the latest changes.
If you could rebase and then address the comments, we should be in a good spot.
|
|
||
| include /etc/os-release | ||
| ifneq ($(wildcard /etc/os-release),) | ||
| -include /etc/os-release |
Contributor
There was a problem hiding this comment.
Since you are doing the check above for the existence of the os-release file, then you don't need the - before the include. I mean, no harm, it is just redundant.
|
|
||
| ifneq (,$(findstring rhel,$(ID_LIKE))) | ||
| ELFLAG := -DEL$(VERSION_ID) | ||
| ifneq (,$(VERSION_ID)) |
Contributor
There was a problem hiding this comment.
Why are we adding a check for $VERSION_ID? If ID_LIKE is not set because there is no os-release file, then this block would be skipped anyways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the /etc/os-release include in the Makefile optional. Without it, the build fails on systems that don't have it, e.g. minimalistic chroot environments where evdi is built as in-tree module.