[ENG-2096] Remove the discourse context overlay from Roam canvas - #1288
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| [pathKey([PERSONAL_KEYS.disableSidebarOpen]), "disable-sidebar-open"], | ||
| [pathKey([PERSONAL_KEYS.hideFeedbackButton]), "hide-feedback-button"], | ||
| [pathKey([PERSONAL_KEYS.autoCanvasRelations]), "auto-canvas-relations"], | ||
| [ |
There was a problem hiding this comment.
Legacy migration iterates Object.values(PERSONAL_KEYS), so with the key gone this map entry is never looked up — old graphs simply skip migrating the dead setting.
| .default({ modifiers: 0, key: "" }), | ||
| "Discourse context overlay": z.boolean().default(false), | ||
| "Reified relation triples": z.boolean().default(true), | ||
| "Overlay in canvas": z.boolean().default(false), |
There was a problem hiding this comment.
PersonalSettingsSchema is a non-strict z.object, so a persisted "Overlay in canvas" prop is stripped on parse. Writes path-patch rather than rewrite the object, so the stale boolean stays in old users' block props — harmless residue, not worth a cleanup migration.
| const isEditing = this.editor.getEditingShapeId() === shape.id; | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks | ||
| const [overlayMounted, setOverlayMounted] = useState(false); | ||
| // eslint-disable-next-line react-hooks/rules-of-hooks |
There was a problem hiding this comment.
overlayMounted + the onPointerEnter handler below existed solely to defer overlay mounting until hover; they go with the overlay.
1 participant
Removes the canvas discourse context overlay and the "(BETA) Overlay in canvas" personal setting. Stacked on ENG-2037 (#1272) — the node card context menu is now the single way to view relations on canvas. Replacement decision per ENG-2037 and the Roam decision page linked in ENG-2096; FEE-881 (which proposed keeping the overlay) was canceled.
Also drops the setting from the zod schema, PERSONAL_KEYS, and the legacy key migration map. Old stored values are ignored harmlessly since the schema is non-strict, so no data migration is needed. Outlines/linked-references overlays are untouched (out of scope per the ticket).
No tests covered the canvas overlay path, so none were removed.