ENG-519 Make human-readable labels for node ids by maparent · Pull Request #1271 · DiscourseGraphs/discourse-graph

maparent · 2026-07-30T21:00:18Z

https://linear.app/discourse-graphs/issue/ENG-519/make-human-readable-labels-for-node-ids

https://www.loom.com/share/e8b03f27c6a947fbaea0ebf416a0981b

Since the loom, I extracted the MetadataTypeManager from obsidian-types. I also unified other unofficial aspects in the obsidianUnofficialTypes.ts, and refactored a few files to use that instead of ad-hoc.

linear-code · 2026-07-30T21:00:23Z

ENG-519

supabase · 2026-07-30T21:00:24Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

vercel · 2026-07-30T21:00:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
discourse-graph	Skipped		Aug 10, 2026 8:31pm

devin-ai-integration

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

graphite-app · 2026-08-04T10:49:40Z

PR size/scope check

This PR is over our review-size guideline.

Recommended: ~200 lines changed
Acceptable limit: up to 400 lines when well-scoped/self-contained
Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

What single problem this PR solves
Why the files/changes are coupled

…idget

mdroidian · 2026-08-07T22:01:04Z

@codex review

mdroidian · 2026-08-07T22:01:29Z

@trangdoan982 would you mind reviewing this?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08e80f82b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

registerNodeTypeIdPropertyWidget previously overwrote any pre-existing widget assignment for nodeTypeId without saving it, and unload always called unsetType, silently discarding the user's prior property-type configuration. Capture the previous assignment before setType and restore it on unload instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

trangdoan982 · 2026-08-10T18:00:21Z

+    const nodeType = getNodeTypeById(plugin, nodeTypeId);
+
+    const el = containerEl.createSpan({
+      cls: "dg-node-type-id-value",


stale class

trangdoan982 · 2026-08-10T18:08:22Z

@@ -0,0 +1,102 @@
+import type {


nit: fileName in components should be CamelCase

trangdoan982

mostly nit

trangdoan982 · 2026-08-10T18:13:09Z

@maparent can you hold off on merging to main? i'm experiencing some bugs with the obsidian-main.yaml workflow that I need to fix in ENG-2099: Test Obsidian Linear release pipeline first. Alternatively to unblock, upon merge, you can stop that github action

vercel Bot deployed to Preview July 30, 2026 21:01 View deployment

devin-ai-integration Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/obsidian/src/components/nodeTypeIdPropertyWidget.ts Outdated

Comment thread apps/obsidian/src/utils/nodeTypeIdPropertyWidget.ts Outdated

Comment thread apps/obsidian/src/components/nodeTypeIdPropertyWidget.ts

maparent marked this pull request as draft July 30, 2026 21:02

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from b761a64 to 4956cbc Compare July 30, 2026 22:17

vercel Bot deployed to Preview July 30, 2026 22:18 View deployment

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 4956cbc to 974bfa0 Compare August 1, 2026 16:36

vercel Bot deployed to Preview August 1, 2026 16:37 View deployment

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 974bfa0 to 24a2c92 Compare August 3, 2026 20:53

vercel Bot deployed to Preview August 3, 2026 20:55 View deployment

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 24a2c92 to bb47db8 Compare August 3, 2026 20:59

vercel Bot temporarily deployed to Preview August 4, 2026 03:01 Inactive

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 1e10a90 to 422ca86 Compare August 4, 2026 03:11

vercel Bot deployed to Preview August 4, 2026 03:11 View deployment

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from 422ca86 to e599ea4 Compare August 4, 2026 03:13

vercel Bot temporarily deployed to Preview August 4, 2026 03:13 Inactive

maparent requested a review from mdroidian August 4, 2026 03:15

maparent marked this pull request as ready for review August 4, 2026 10:49

mdroidian requested changes Aug 4, 2026

View reviewed changes

Comment thread apps/obsidian/package.json Outdated

maparent added 3 commits August 5, 2026 08:21

eng-519-human-readable-label-for-node-type-Claude-nodeTypeIdPropertyW…

0b0a483

…idget

add try-catch clauses

db4605f

obsidianUnofficialTypes

fd3f363

maparent force-pushed the eng-519-make-human-readable-labels-for-node-ids branch from e599ea4 to fd3f363 Compare August 5, 2026 12:25

vercel Bot temporarily deployed to Preview August 5, 2026 12:25 Inactive

graphite-app Bot reviewed Aug 5, 2026

View reviewed changes

Comment thread apps/obsidian/src/utils/nodeTypeIdPropertyWidget.ts Outdated

maparent added 2 commits August 5, 2026 10:33

consistent registration

96c67a1

move widget to components. Remove unused exports. Name the widget types.

e05dfa6

vercel Bot temporarily deployed to Preview August 5, 2026 14:43 Inactive

use bare minimum from MetadataTypeManager

3776d1a

vercel Bot temporarily deployed to Preview August 5, 2026 17:00 Inactive

maparent requested a review from mdroidian August 5, 2026 20:14

remove dependencies accordingly

08e80f8

vercel Bot temporarily deployed to Preview August 6, 2026 14:13 Inactive

mdroidian requested a review from trangdoan982 August 7, 2026 22:00

chatgpt-codex-connector Bot reviewed Aug 7, 2026

View reviewed changes

Comment thread apps/obsidian/src/components/nodeTypeIdPropertyWidget.ts Outdated

Comment thread apps/obsidian/src/components/nodeTypeIdPropertyWidget.ts Outdated

maparent and others added 2 commits August 10, 2026 07:49

add another catch

245f7db

vercel Bot temporarily deployed to Preview August 10, 2026 11:52 Inactive

trangdoan982 reviewed Aug 10, 2026

View reviewed changes

Comment thread apps/obsidian/src/utils/obsidianUnofficialTypes.ts

trangdoan982 reviewed Aug 10, 2026

View reviewed changes

trangdoan982 approved these changes Aug 10, 2026

View reviewed changes

Comment thread apps/obsidian/src/utils/obsidianUnofficialTypes.ts Outdated

Comment thread apps/obsidian/src/components/nodeTypeIdPropertyWidget.ts Outdated

Comment thread apps/obsidian/src/utils/obsidianUnofficialTypes.ts

nits

1fc7243

vercel Bot temporarily deployed to Preview August 10, 2026 20:31 Inactive

Uh oh!

Conversation

maparent commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear-code Bot commented Jul 30, 2026

Uh oh!

supabase Bot commented Jul 30, 2026

Uh oh!

vercel Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

graphite-app Bot commented Aug 4, 2026

PR size/scope check

Uh oh!

Uh oh!

Uh oh!

mdroidian commented Aug 7, 2026

Uh oh!

mdroidian commented Aug 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

trangdoan982 Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trangdoan982 Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

trangdoan982 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trangdoan982 commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maparent commented Jul 30, 2026 •

edited

Loading

vercel Bot commented Jul 30, 2026 •

edited

Loading