ENG-1856 Store source identity metadata for Roam imported nodes#1218
Open
sid597 wants to merge 27 commits into
Open
ENG-1856 Store source identity metadata for Roam imported nodes#1218sid597 wants to merge 27 commits into
sid597 wants to merge 27 commits into
Conversation
Roam's command palette runs commands on Enter keyup, which landed as a click on the dialog's autofocused close button and dismissed it instantly. Disable autoFocus/enforceFocus like AdvancedSearchDialog and restore outside-click close. Also from review: use Tailwind classes instead of inline styles, drop the unused ValidSharedSpace.id field, and unexport the file-internal getImportedSourceRids.
Replaces the hand-rolled paging loop with the existing @repo/database/lib/pagination helper, matching how syncDgNodesToSupabase already reads ResourceAccess.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Collaborator
Author
|
@codex review |
sid597
marked this pull request as ready for review
July 10, 2026 17:37
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
…red-node-import-discovery-v2
…port-discovery-v2' into eng-2019-extract-shared-cross-space-node-discovery-into
…ed-cross-space-node-discovery-into
…ng, created fallback
sid597
force-pushed
the
eng-1856-store-source-identity-metadata-for-roam-imported-nodes-v2
branch
from
July 21, 2026 08:59
39dc8cb to
9b7eaf7
Compare
…ry loop Remove the isRid(source_local_id) short-circuit — source_local_id is never a RID in current Roam/Obsidian flows, so rid is always derived via spaceUriAndLocalIdToRid; drop the RID-preservation test that asserted it. Flatten the per-space discovery loop into a single chunked pass over deduped source_local_ids. buildSharedNodes already narrows by the composite (spaceId, sourceLocalId) key, so no per-space DB query is needed.
Per maparent (review on sharedNodes.ts:311/316): drop getGroupSharedResources and the chunked .in("source_local_id") lookup. my_concepts/my_contents already fold ResourceAccess into their RLS via my_accessible_resources(), so query the views directly with .neq("space_id", currentSpaceId). This makes the resources/sharedResourceKeys filter in buildSharedNodes redundant, so it and the two unit tests pinning it are removed.
Per mdroidian (sharedNodes.ts:92): the input is the shared node instances, so name it nodes. Row type stays SharedConcept; the CrossAppNode contract migration is deferred to the next project per the same comment.
sid597
force-pushed
the
eng-1856-store-source-identity-metadata-for-roam-imported-nodes-v2
branch
from
July 24, 2026 09:06
9b7eaf7 to
9eb8f9f
Compare
…ia contract alias, drop duplicate warn, validate query result
…-identity-metadata-for-roam-imported-nodes-v2 # Conflicts: # apps/roam/src/utils/discoverSharedNodes.ts
sid597
changed the base branch from
eng-2019-extract-shared-cross-space-node-discovery-into
to
main
July 24, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discourse-graph.importedFromsourceNodeRidas the canonical cross-app identity and keepsourceModifiedAtas refresh stateWhy
Roam needs a stable way to recognize an imported shared node after its page title or content changes. Matching by display title would make duplicate prevention and refresh dependent on presentation and namespace decisions.
Obsidian already uses
importedFromRidas the canonical imported identity and stores the imported source timestamp aslastModified. This implementation follows the same boundary in Roam:sourceNodeRidis the identitysourceModifiedAtis refresh stateThis supersedes the closed v1 PR, #1161, and addresses its review feedback about the redundant six-field identity shape.
Implementation
The metadata is stored in page/block props rather than page content:
Writing merges the existing
discourse-graphobject so unrelated metadata, including relation migration state, survives. Content replacement during import or refresh does not touch these block props.The helper exposes:
Dependency
This PR is intentionally stacked on ENG-2019 / #1216, which is itself stacked on ENG-1855. ENG-1855 introduced the Roam discovery consumer and ENG-2019 extracted the cross-space listing logic while leaving already-imported detection app-side.
Once #1216 merges, this PR can be retargeted to
mainwithout changing the ENG-1856 implementation diff.Validation
pnpm --filter roam test -- src/utils/__tests__/importedSourceIdentity.test.ts src/utils/__tests__/discoverSharedNodes.test.tspnpm --filter roam check-typesgit diff --checkThe local shell reports Node 20 while the repository declares Node 22+, but all checks above completed successfully.