Add explicit OpenLDAP password changes with Argon2 support - #809
Draft
stevebauman wants to merge 1 commit into
Draft
Add explicit OpenLDAP password changes with Argon2 support#809stevebauman wants to merge 1 commit into
stevebauman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds Argon2 password support for OpenLDAP and exposes password changes as an explicit model operation:
{ARGON2}scheme.OpenLDAP\User::changePassword()for immediate self-service password changes.save().$user->password = [$old, $new]with guidance to usechangePassword().Why
The existing password-change flow removes the old stored hash and adds a newly generated hash. Argon2 hashes use a random salt, so the client cannot reproduce the stored value needed for that removal.
Using the directory's Password Modify extended operation lets the server verify the current password and apply its configured hashing and password policies. Keeping this operation separate from
save()also avoids retaining plaintext credentials on the model or combining non-atomic LDAP operations under one model save.Validation