Replace per-field message fetch state with composable fetch items - #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message fetch selection currently requires a boolean property, state getter, fluent inclusion method, fluent exclusion method, and command-builder condition for every supported data item. This makes each new FETCH item expand the public query contract and spreads protocol knowledge across the query implementation.
This introduces a uniform MessageData API for composing requests through with(), without(), and only(). Fixed attributes are represented internally by enum values, while BODY sections are immutable objects that can be transformed with peek() without adding global query state or applying irrelevant options to other data items.
For example:
All message data items implement the same FetchItem contract, so the query only needs to serialize the selected items. FETCH response parsing and message construction now live in FetchedMessageData, keeping MessageQuery focused on search, ordering, pagination, and execution.