Fix leak in manganis iOS FFI wrappers: hold Retained<AnyObject> instead of a raw pointer - #5733
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
jkelleyrtp
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5722.
The iOS/macOS wrappers generated by
#[manganis::ffi]constructed their Objective-C instance withalloc+init(+1 retain) and stored it as a bare*mut AnyObject, so dropping the Rust value never sentrelease— everyBridge::new()leaked its object (and any system resource it owned, e.g. aCLLocationManager). The Android arm already had correct ownership viajni::objects::GlobalRef.The generated type now holds
objc2::rc::Retained<AnyObject>, which takes over the +1 reference and releases on drop:from_raw(ptr)likewise wraps the pointer inRetained::from_rawand is documented as taking ownership of a +1 reference (it now panics on null).Verified the generated code shape type-checks against objc2 0.6.4 on
aarch64-apple-darwin(full cross-check of the macro output isn't possible on Linux CI hosts sinceobjc2-exception-helperneeds an ObjC compiler).Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/cd9de105cf904808b16b468c829b5ac1
Requested by: @nicoburns