Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3baaa9d6ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| host = "OpenLinkDirectly" | ||
| parameters.append("url", url) | ||
| }.toString(), | ||
| originalUrl = url, |
There was a problem hiding this comment.
Setting DeepLinkAccountPicker.originalUrl to the raw HTTP URL makes the desktop picker’s browser action (desktopApp/src/main/kotlin/dev/dimension/flare/ui/screen/home/DeepLinkAccountPicker.kt, openUri(originalUrl)) feed that URL back into DeepLinkPresenter, which re-matches accounts and routes to the picker again instead of calling onLink. In practice, clicking “Open in browser” on desktop loops back to account selection and never reaches the system browser. This value needs to stay an OpenLinkDirectly(...).toUri() deeplink (or the desktop action must wrap it) so the presenter takes the DeeplinkRoute.OpenLinkDirectly path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c009db320
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (inAppBrowser) { | ||
| val builder = CustomTabsIntent.Builder() | ||
| val customTabsIntent = builder.build() | ||
| customTabsIntent.launchUrl(context, url.toUri()) |
There was a problem hiding this comment.
openInBrowser now calls CustomTabsIntent.launchUrl without any error handling, so devices/environments without a Custom Tabs-capable activity (or with browser intents blocked) will throw and crash instead of falling back to fallbackOpenUrl. The previous implementation guarded this path and degraded gracefully, so this change introduces a crash regression for those users whenever they tap an HTTP(S) link with in-app browser enabled.
Useful? React with 👍 / 👎.
1 participant
No description provided.