Skip to content

mx-bluesky#1765 Refactor grid parameters#2112

Draft
rtuck99 wants to merge 1 commit into
mainfrom
mx-bluesky_1765_grid_scan_params_refactor
Draft

mx-bluesky#1765 Refactor grid parameters#2112
rtuck99 wants to merge 1 commit into
mainfrom
mx-bluesky_1765_grid_scan_params_refactor

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Part of fix for:

See also:

This removes grid_position_to_motor_position(). The function is now part of xrc_result_utils in mx-bluesky.

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (700c0b3) to head (6e61e48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   99.16%   99.09%   -0.07%     
==========================================
  Files         347      347              
  Lines       13588    13588              
==========================================
- Hits        13474    13465       -9     
- Misses        114      123       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant