Update to ophyd-async 0.19.3#2111
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2111 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 347 347
Lines 13588 13588
=======================================
Hits 13474 13474
Misses 114 114 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated devices and tests to work with ophyd-async 0.19.3. The robot tests were failing with the below:
/workspaces/dodal/tests/devices/test_gridscan.py::test_timeout_on_complete_triggers_stop_and_logs_error failed: Traceback (most recent call last): File "/root/.local/share/uv/python/cpython-3.11.15-linux-x86_64-gnu/lib/python3.11/warnings.py", line 538, in _warn_unawaited_coroutine warn(msg, category=RuntimeWarning, stacklevel=2, source=coro) RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/runner.py", line 353, in from_call result: TResult | None = func() ^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/runner.py", line 245, in <lambda> lambda: runtest_hook(item=item, **kwds), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_hooks.py", line 512, in __call__ return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_manager.py", line 120, in _hookexec return self._inner_hookexec(hook_name, methods, kwargs, firstresult) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 167, in _multicall raise exception File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall teardown.throw(exception) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/logging.py", line 850, in pytest_runtest_call yield File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall teardown.throw(exception) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 53, in run_old_style_hookwrapper return result.get_result() ^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_result.py", line 103, in get_result raise exc.with_traceback(tb) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 38, in run_old_style_hookwrapper res = yield ^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall teardown.throw(exception) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/capture.py", line 900, in pytest_runtest_call return (yield) ^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall teardown.throw(exception) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 53, in run_old_style_hookwrapper return result.get_result() ^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_result.py", line 103, in get_result raise exc.with_traceback(tb) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 38, in run_old_style_hookwrapper res = yield ^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 139, in _multicall teardown.throw(exception) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/skipping.py", line 268, in pytest_runtest_call return (yield) ^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/pluggy/_callers.py", line 121, in _multicall res = hook_impl.function(*args) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/unraisableexception.py", line 158, in pytest_runtest_call collect_unraisable(item.config) File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/unraisableexception.py", line 79, in collect_unraisable raise errors[0] File "/cache/venv-for/scratch/bluesky_development/dodal/lib/python3.11/site-packages/_pytest/unraisableexception.py", line 67, in collect_unraisable warnings.warn(pytest.PytestUnraisableExceptionWarning(msg)) pytest.PytestUnraisableExceptionWarning: Exception ignored in: <coroutine object AsyncMockMixin._execute_mock_call at 0x7fe68dd75840> Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.So have also fixed this.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}