Skip to content

Add blower control for i15-1#2110

Open
DominicOram wants to merge 2 commits into
mainfrom
2109_blower
Open

Add blower control for i15-1#2110
DominicOram wants to merge 2 commits into
mainfrom
2109_blower

Conversation

@DominicOram

@DominicOram DominicOram commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #2109

Need to merge DiamondLightSource/crystallography-bluesky#93 at the same time

Instructions to reviewer on how to test:

  1. Confirm tests pass
  2. Confirm a dodal connect i15-1 passes

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner June 30, 2026 17:01
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.15%. Comparing base (700c0b3) to head (477c688).

Files with missing lines Patch % Lines
src/dodal/devices/beamlines/i15_1/blower.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
- Coverage   99.16%   99.15%   -0.01%     
==========================================
  Files         347      347              
  Lines       13588    13608      +20     
==========================================
+ Hits        13474    13493      +19     
- Misses        114      115       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i15-1: Implement logic for the blower

1 participant