Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 34 additions & 27 deletions src/ui/widgets/DynamicImage/demoImage.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import React from "react";
import { fireEvent, render, screen } from "@testing-library/react";
import {
act,
fireEvent,
render,
screen,
waitFor
} from "@testing-library/react";
import { DemoImageComponent, buildMjpgPvUrls } from "./demoImage";
import { newColor } from "../../../types/color";
import { vi } from "vitest";
Expand Down Expand Up @@ -84,41 +90,39 @@ describe("DemoImageComponent", () => {
/>
);

const img = screen.getByRole("img");

expect(img).toHaveAttribute("src", "http://a/TEST:PV");
expect(screen.getByRole("img")).toHaveAttribute("src", "http://a/TEST:PV");

fireEvent.error(img);
expect(img).toHaveAttribute("src", "http://b/TEST:PV");
fireEvent.error(screen.getByRole("img"));
expect(screen.getByRole("img")).toHaveAttribute("src", "http://b/TEST:PV");

fireEvent.error(img);
expect(img).toHaveAttribute("src", "http://c/TEST:PV");
fireEvent.error(screen.getByRole("img"));
expect(screen.getByRole("img")).toHaveAttribute("src", "http://c/TEST:PV");
});

it("shows warning when all URLs fail", () => {
it("shows warning when all URLs fail", async () => {
const data = [
{ value: newDType({ stringValue: "ignored" }, DAlarmNONE()) } as PvDatum
];

render(
<DemoImageComponent
macros={{}}
pvData={data}
mjpgEndpoints={["http://a", "http://b"]}
/>
);

const img = screen.getByRole("img");
const { getByRole } = await act(() => {
return render(
<DemoImageComponent
macros={{}}
pvData={data}
mjpgEndpoints={["http://a", "http://b"]}
/>
);
});

fireEvent.error(img); // move to second URL
fireEvent.error(img); // no more URLs → warning
fireEvent.error(getByRole("img")); // move to second URL
fireEvent.error(getByRole("img")); // no more URLs → warning

expect(showWarningMock).toHaveBeenCalledWith(
"Could not load mjpg image stream for the PV: TEST:PV"
);
});

it("resets failure counter after exhausting URLs", () => {
it("resets failure counter after exhausting URLs", async () => {
const data = [
{ value: newDType({ stringValue: "ignored" }, DAlarmNONE()) } as PvDatum
];
Expand All @@ -131,15 +135,18 @@ describe("DemoImageComponent", () => {
/>
);

const img = screen.getByRole("img");

fireEvent.error(img); // → b
fireEvent.error(img); // → warning + reset
fireEvent.error(screen.getByRole("img")); // → b
fireEvent.error(screen.getByRole("img")); // → warning + reset

// Trigger again → should start sequence again from second URL
fireEvent.error(img);
fireEvent.error(screen.getByRole("img"));

expect(img).toHaveAttribute("src", "http://b/TEST:PV");
await waitFor(() => {
expect(screen.getByRole("img")).toHaveAttribute(
"src",
"http://b/TEST:PV"
);
});
});

it("handles missing endpoints without crashing", () => {
Expand Down
7 changes: 6 additions & 1 deletion src/ui/widgets/DynamicImage/demoImage.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from "react";
import React, { useEffect, useState } from "react";
import { Widget } from "../widget";
import { PVComponent, PVWidgetPropType } from "../widgetProps";
import {
Expand Down Expand Up @@ -86,9 +86,14 @@ export const DemoImageComponent = (
}
};

useEffect(() => {
setSrc(urls?.[numberOfFailures]);
}, [urls, numberOfFailures]);

return (
<Box
component="img"
key={`image_${crypto.randomUUID()}`}
src={src}
alt={`PvName: ${effectivePvName}`}
onError={handleError}
Expand Down
Loading