fix: get tasks endpoint to a enum#1578
Open
ZohebShaikh wants to merge 4 commits into
Open
Conversation
ZohebShaikh
force-pushed
the
add-enum-for-endpoint
branch
from
075e64b to
ba64006
Compare
ZohebShaikh
force-pushed
the
add-enum-for-endpoint
branch
from
ba64006 to
a5fbf0a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
- Coverage 95.93% 95.91% -0.03%
==========================================
Files 44 44
Lines 3270 3253 -17
==========================================
- Hits 3137 3120 -17
Misses 133 133 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tpoliaw
reviewed
Jun 30, 2026
Contributor
There was a problem hiding this comment.
I think if we accept an enum, fastapi will do this validation for us so the block can be removed
Contributor
Author
There was a problem hiding this comment.
This is true, While I was going through the code I thought I will remove the get_tasks function as well and simplify it a little bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently get_tasks takes a string to filter on task_status, but it should be a enum.