Skip to content

perf(ui): look up cycle/module names via maps on the issue list #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martian56 merged 1 commit into from
Jul 25, 2026
+8 −2
Merged

perf(ui): look up cycle/module names via maps on the issue list #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/web/src/pages/IssueListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,14 +590,20 @@ export function IssueListPage() {
const dp = listDisplay.displayProperties;
const hasCol = (id: SavedViewDisplayPropertyId) => dp.has(id);

// Build id -> name maps once per render instead of doing an O(cycles) /
// O(modules) find for every row. (Plain consts, not useMemo, because this
// sits after the component's early returns.)
const cycleNameById = new Map(cycles.map((c) => [c.id, c.name]));
const moduleNameById = new Map(modules.map((m) => [m.id, m.name]));

const cycleName = (issue: IssueApiResponse) => {
const id = issue.cycle_ids?.[0];
return id ? (cycles.find((c) => c.id === id)?.name ?? '—') : '—';
return id ? (cycleNameById.get(id) ?? '—') : '—';
};

const moduleName = (issue: IssueApiResponse) => {
const id = issue.module_ids?.[0];
return id ? (modules.find((m) => m.id === id)?.name ?? '—') : '—';
return id ? (moduleNameById.get(id) ?? '—') : '—';
};

const layout = parseIssueLayout(searchParams.get('layout'));
Expand Down
Loading