Skip to content

fix(api): download attachments instead of rendering them inline #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cavidelizade wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(api): download attachments instead of rendering them inline #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/api/internal/handler/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,14 @@ func (h *UploadHandler) ServeFile(c *gin.Context) {

c.Header("Content-Type", info.ContentType)
c.Header("X-Content-Type-Options", "nosniff")
c.Header("Content-Disposition", "inline")
// Attachments are arbitrary user files with an unvalidated content-type, so
// force a download instead of rendering them inline: an uploaded .html or
// SVG would otherwise execute on the API origin when opened. The uploads/
// prefix (avatars, covers, logos) is validated as images and stays inline.
disposition := "inline"
if strings.HasPrefix(path, "attachments/") {
disposition = "attachment"
}
c.Header("Content-Disposition", disposition)
c.DataFromReader(http.StatusOK, info.Size, info.ContentType, obj, nil)
}
Loading